Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <1295912276.3851267521567320.JavaMail.jira@brutus.apache.org>
Date: Tue, 2 Mar 2010 09:19:27 +0000 (UTC)
From: =?utf-8?Q?Matthias_We=C3=9Fendorf_=28JIRA=29?= <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Commented: (TRINIDAD-1680) Introduce include-property in CSS
In-Reply-To: <1490316548.117821262942755055.JavaMail.jira@brutus.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/TRINIDAD-1680?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1=
2840075#action_12840075 ]=20

Matthias We=C3=9Fendorf commented on TRINIDAD-1680:
----------------------------------------------

the code should be formarted as the other Trinidad code does; requiring som=
e JDEV specific formating seems wrong for an Apache project.

In there we use two spaces, not four. no TAB etc.

In your patch:
https://issues.apache.org/jira/secure/attachment/12437587/includeProperty.p=
atch

I see this:
+af|commandButton {
+    -tr-include-property: property(selector=3D".AFTestBackgroundColor:alia=
s",propertyName=3D"background-color",localPropertyName=3D"background-color"=
);
+}

which uses 4 spaces.

the file in question (in SVN) is doing this:
af|panelTabbed::orientation-bottom
{
  border-top: 3px solid black;
}

which is "just" two spaces.


Ideally we have check-style for all kind of formats. Otherwise we can't con=
trol the format of patches... and denying patches just b/c of formarting is=
sues is IMO wrong, especially when there is no check-style at all :-)

> Introduce include-property in CSS
> ---------------------------------
>
>                 Key: TRINIDAD-1680
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1680
>             Project: MyFaces Trinidad
>          Issue Type: New Feature
>          Components: Skinning
>            Reporter: Marius Petoi
>            Priority: Minor
>         Attachments: includeProperty.patch, includeProperty.patch, patchI=
ncludeProperty.patch
>
>
> The include-property feature is present in the XSS, but it is not support=
ed in the CSS. With this, we are one step closer to eliminating the old XSS=
 files and replacing them with CSS. In the XSS files, the syntax of include=
Property is:
>  <!-- AFVeryDarkForeground is the darkest foreground color in the core (g=
reen)
>      color ramp -->
>  <style name=3D"AFVeryDarkForeground">
>   <includeProperty name=3D"AFVeryDarkBackground"
>                    propertyName=3D"background-color"
>                    localPropertyName=3D"color"/>
>  </style>
> This should be ported to CSS also.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.