myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2621) BeanValidation does not work with Unified EL 2.2
Date Mon, 29 Mar 2010 12:45:27 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850899#action_12850899
] 

Jakob Korherr commented on MYFACES-2621:
----------------------------------------

So this works now perfectly :)

The only thing which I really don't like now is that we are calling ExternalSpecifications.isUnifiedELAvailable()
very often (for every ValueExpression in TagAttributeImpl at least once) and this method is
synchronized. And frankly, I really don't understand why this one has to be synchronized.
It is null at first and then it changes to Boolean.TRUE or Boolean.FALSE and is never changed
again, as Leonardo wrote before. When we're removing synchronized the only thing which can
happen is that more than one thread sets it from null to true or false, but this really is
no problem, because every thread will come up with the same result here!

So removing synchronized should not cause any problems here or am I missing something? What
were your concerns, Jan-Kees?



> BeanValidation does not work with Unified EL 2.2
> ------------------------------------------------
>
>                 Key: MYFACES-2621
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2621
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-3
>         Environment: bean validation 1.0.0.GA, unified el 2.2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>
> When using the new Unified EL 2.2, BeanValidation does not work, because _BeanValidatorUELUtils.getUELValueReferenceWrapper()
always returns null.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55250.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message