myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2623) validation-api and el-api 2.2 should be optional dependencies with scope compile in myfaces-api
Date Thu, 25 Mar 2010 16:43:27 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849768#action_12849768
] 

Jakob Korherr commented on MYFACES-2623:
----------------------------------------

Yes I tried the trinidad demo, because I knew that there were problems with it.. and it worked
;)

I really did check the svn history here, believe it or not. Also I could still remember those
issues, because they were created just one or two weeks ago. Please don't always tell me to
take a breath before doing something - I really do that. I'm not just committing something
because it's fun, I do it for a reason!! Actually it would be cool if you took a breath here,
before telling me that all this was wrong!

The problem with your committed solution, Leonardo, was that you set scope to provided and
optional to true, but this combination is invalid (please take a look at the maven documentation),
so this had to be changed. Optional makes only sence with scope compile. See http://svn.apache.org/viewvc/myfaces/core/trunk/api/pom.xml?p2=%2Fmyfaces%2Fcore%2Ftrunk%2Fapi%2Fpom.xml&p1=%2Fmyfaces%2Fcore%2Ftrunk%2Fapi%2Fpom.xml&r1=923936&r2=923935&view=diff&pathrev=923936
for the svn-diff of your commit.

Furthermore I did not remove the dependencies from the parent-pom by accident, it was well-thought.
Again - believe it or not...

Anyway, I hope that you will be able to trust me a little bit more with such things. It would
mean a lot to me ;)

> validation-api and el-api 2.2 should be optional dependencies with scope compile in myfaces-api
> -----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2623
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2623
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: build process
>    Affects Versions: 2.0.0-beta-3
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>             Fix For: 2.0.0-beta-4
>
>
> Currently those two dependencies are defined messy. First they are defined in myfaces-core-project
as optional which makes no sence since this project is just the super-project for api and
impl and optional dependencies are not transitive. So this has to be removed here.
> Furthermore the definitions of validation-api and el-api in the pom of myfaces-api are
not completely correct. They should have a scope of compile (default) and should have set
optional to true instead of just provided or provided+optional (which is by the way not allowed).
> After this issue has been resolved el-api 2.2 will be available on the whole myfaces-api
project, however keep in mind that you are only allowed to use the new methods (like getValueReference())
if you checked if the el-api 2.2 is really available first (via ExternalSpecifications). Otherwise
you will end up in ClassNotFoundExceptions at runtime when el-api 2.2 is not available in
the target system.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message