myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2623) validation-api and el-api 2.2 should be optional dependencies with scope compile in myfaces-api
Date Wed, 24 Mar 2010 18:59:27 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849357#action_12849357
] 

Jakob Korherr commented on MYFACES-2623:
----------------------------------------

No this should not be closed as invalid!!

I prevent that from happening if I set optional to true, furthermore the way it is at the
moment is completely wrong.

I know your code from ExternalSpecifications and also from _BeanValidatorUELUtils. This is
the way it has to happen, I agree! But if I don't set the dependency to el-api 2.2 I would
have to use reflection for all methods here and this is the thing I don't want!

At the moment I am testing this configuration with many servers including jetty 6 and jetty
7 via the maven plugins and it is working without any problems ;)

> validation-api and el-api 2.2 should be optional dependencies with scope compile in myfaces-api
> -----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2623
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2623
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: build process
>    Affects Versions: 2.0.0-beta-3
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>
> Currently those two dependencies are defined messy. First they are defined in myfaces-core-project
as optional which makes no sence since this project is just the super-project for api and
impl and optional dependencies are not transitive. So this has to be removed here.
> Furthermore the definitions of validation-api and el-api in the pom of myfaces-api are
not completely correct. They should have a scope of compile (default) and should have set
optional to true instead of just provided or provided+optional (which is by the way not allowed).
> After this issue has been resolved el-api 2.2 will be available on the whole myfaces-api
project, however keep in mind that you are only allowed to use the new methods (like getValueReference())
if you checked if the el-api 2.2 is really available first (via ExternalSpecifications). Otherwise
you will end up in ClassNotFoundExceptions at runtime when el-api 2.2 is not available in
the target system.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message