Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 70559 invoked from network); 9 Feb 2010 19:47:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 9 Feb 2010 19:47:50 -0000 Received: (qmail 68953 invoked by uid 500); 9 Feb 2010 19:47:49 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 68886 invoked by uid 500); 9 Feb 2010 19:47:49 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 68878 invoked by uid 99); 9 Feb 2010 19:47:49 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Feb 2010 19:47:49 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Feb 2010 19:47:48 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 3153A234C052 for ; Tue, 9 Feb 2010 11:47:28 -0800 (PST) Message-ID: <194148419.158291265744848200.JavaMail.jira@brutus.apache.org> Date: Tue, 9 Feb 2010 19:47:28 +0000 (UTC) From: "Jeanne Waldman (JIRA)" To: dev@myfaces.apache.org Subject: [jira] Resolved: (TRINIDAD-1714) Mark the skin as dirty if DesignTime mode and org.apache.myfaces.trinidad.skin.id is set. In-Reply-To: <1087232364.136661265675248003.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TRINIDAD-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeanne Waldman resolved TRINIDAD-1714. -------------------------------------- Resolution: Fixed Fix Version/s: 1.2.14-core > Mark the skin as dirty if DesignTime mode and org.apache.myfaces.trinidad.skin.id is set. > ----------------------------------------------------------------------------------------- > > Key: TRINIDAD-1714 > URL: https://issues.apache.org/jira/browse/TRINIDAD-1714 > Project: MyFaces Trinidad > Issue Type: Improvement > Reporter: Jeanne Waldman > Assignee: Jeanne Waldman > Fix For: 1.2.14-core > > Attachments: 1714patchfor12122.patch > > > Our Design Time team wasn't satisfied with "TRINIDAD-1637 always check for file modification if in DesignTime mode regardless of web.xml setting". > Instead, they'd rather if we always update the skin. Since we now have the skin.isDirty/setDirty apis, we can use those. > The fix for this is in StyleContextImpl. Revert the change for 1637 and in StyleContextImpls's isDirty, return true if DesignTime mode && flag is set. Also, in this case, setDirty to true on the skin in case someone is checking the skin instead of the StyleContext. > Also, in FileSystemStyleCache, instead of calling skin.isDirty, call styleContext.isDirty like I should have done in the first place. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.