myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ganesh Jung (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2564) facelets in an app with a 1.2 level faces-config do not work
Date Fri, 19 Feb 2010 12:03:27 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835716#action_12835716
] 

Ganesh Jung commented on MYFACES-2564:
--------------------------------------

Sorry for being inaccurate in my previous post by saying "accept" and "reject". I now understand
you're suggesting to disable the integrated JSF 2.0 facelets feature for older faces-config
versions. 

You might be missing the phrase "such an application must *not* continue to bundle the Facelets
jar file along with the application". This says that an application that worked with JSF 1.2
plus facelets is supposed to work with JSF 2.0 without facelets *unchanged*.

IMHO setting the context param should be the only way to disable the integrated facelets feature.
If a developer accidentally adds a jar with com.sun.facelets classes or an older faces-config
to his application he would get caught by surprise if he suddenly realizes that MyFaces decided
to turn his integrated facelets feature of. What could be the use of such a behaviour?



> facelets in an app with a 1.2 level faces-config do not work
> ------------------------------------------------------------
>
>                 Key: MYFACES-2564
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2564
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta
>            Reporter: Michael Concini
>            Assignee: Michael Concini
>
> According to section 10.1.2 of the spec:
> The sole determinant to backwards compatibility lies in the answer to the question, "is
there any Java
> code in the application, or in libraries used by the application, that extends from or
depends on any class in package
> com.sun.facelets and/or its sub-packages?"
> ...
> If the answer to this question is "no", Facelets in JSF 2.0 is backwards compatible with
pre-JSF 2.0 Facelets and such
> an application must not continue to bundle the Facelets jar file along with the application,
and must not continue to set
> the Facelets configuration parameters.
> This implies that simply removing the pre-2.0 facelets bundle should allow the app to
run properly again in a 2.0 runtime.  
> The problem is that right now we're doing a check against the version in the faces-config
in addition to checking for the context param and the availability of the com/sun/facelets
classes.  We should only be doing the latter, as the version in the faces-config should only
be used for schema validation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message