myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Updated: (MYFACES-2544) UIViewRoot skips uncorrectly encodeBegin
Date Wed, 10 Feb 2010 11:08:27 GMT

     [ https://issues.apache.org/jira/browse/MYFACES-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jakob Korherr updated MYFACES-2544:
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.0-beta-2
         Assignee: Jakob Korherr
           Status: Resolved  (was: Patch Available)

This is very interesting. Until now the if part in encodeBegin was never executed, because
facesContext.getRenderResponse() is always true at this point. So maybe there are some unwanted
side effects from the patch. Because of that I added a FIXME in the code.

Martin, maybe you could check if this is a problem with the spec. I noticed that the if path
is not that different from the else path. The only difference is that a PreRenderComponentEvent
is published and I don't know if this is ok. Thanks!

> UIViewRoot skips uncorrectly encodeBegin
> ----------------------------------------
>
>                 Key: MYFACES-2544
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2544
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>         Environment: myfaces trunk
>            Reporter: Martin Koci
>            Assignee: Jakob Korherr
>             Fix For: 2.0.0-beta-2
>
>         Attachments: MYFACES-2544.patch
>
>
> javax.faces.component.UIViewRoot.encodeBegin(FacesContext) contains:
> if (!skipPhase) {
>    super.encodeBegin(context);
> }
> but skipPhase = context.getRenderResponse() || context.getResponseComplete() - it
> makes sense for all phases except render response phase itself. That condition
> probably should be:
> if (!context.getResponseComplete()) {
>             super.encodeBegin(context);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message