myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Koci (JIRA)" <>
Subject [jira] Commented: (MYFACES-2542) Don't throw exception if no SelectItems found
Date Tue, 09 Feb 2010 15:33:27 GMT


Martin Koci commented on MYFACES-2542:

> First the changed class is duplicated in javax.faces.component package (look at the comment
at the top of the class)
Oh! I'm still not sure with api/impl/shared/shared_impl etc.
> Second the patch contains unnecessary imports
Fixed in my IDE settings
> Furthermore you should use FacesContext.isProjectStage() to check the current project
My old habit putttng constants on left side in if-condition
> Also you forgot to add {2} in the log message to print out the type of the value
glasses cleaned
> There are not very strict rules for splitting parameter lists in two or more line
Yes, but settings for eclipse from
did that, but this probably problem that formatter in eclipse 3.5 is too "smart"

> Don't  throw exception if no SelectItems found
> ----------------------------------------------
>                 Key: MYFACES-2542
>                 URL:
>             Project: MyFaces Core
>          Issue Type: New Feature
>          Components: General
>    Affects Versions: 2.0.0-beta-2
>         Environment: myfaces trunk
>            Reporter: Martin Koci
>            Assignee: Jakob Korherr
>            Priority: Trivial
>             Fix For: 2.0.0-beta-2
>         Attachments: MYFACES-2542.patch
> if  <f:selectItems  value="#{aNonExistentModel}" /> resolves in runtime to null
a expection is throw. But having no SelectItem(s) is legal and this state should not breaks
view processing/rendering.  JSF RI  handles this situation without a exception.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message