myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeanne Waldman (JIRA)" <...@myfaces.apache.org>
Subject [jira] Created: (TRINIDAD-1714) Mark the skin as dirty if DesignTime mode and org.apache.myfaces.trinidad.skin.id is set.
Date Tue, 09 Feb 2010 00:27:28 GMT
Mark the skin as dirty if DesignTime mode and org.apache.myfaces.trinidad.skin.id is set.
-----------------------------------------------------------------------------------------

                 Key: TRINIDAD-1714
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1714
             Project: MyFaces Trinidad
          Issue Type: Improvement
            Reporter: Jeanne Waldman
            Assignee: Jeanne Waldman


Our Design Time team wasn't satisfied with "TRINIDAD-1637 always check for file modification
if in DesignTime mode regardless of web.xml setting".
Instead, they'd rather if we always update the skin. Since we now have the skin.isDirty/setDirty
apis, we can use those.

The fix for this is in StyleContextImpl. Revert the change for 1637 and in StyleContextImpls's
isDirty, return true if DesignTime mode && flag is set. Also, in this case, setDirty
to true on the skin in case someone is checking the skin instead of the StyleContext.

Also, in FileSystemStyleCache, instead of calling skin.isDirty, call styleContext.isDirty
like I should have done in the first place.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message