Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 11100 invoked from network); 15 Jan 2010 16:37:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Jan 2010 16:37:16 -0000 Received: (qmail 54933 invoked by uid 500); 15 Jan 2010 16:37:16 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 54860 invoked by uid 500); 15 Jan 2010 16:37:15 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 54852 invoked by uid 99); 15 Jan 2010 16:37:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jan 2010 16:37:15 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jan 2010 16:37:14 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 751EE234C4AB for ; Fri, 15 Jan 2010 08:36:54 -0800 (PST) Message-ID: <570214543.266271263573414478.JavaMail.jira@brutus.apache.org> Date: Fri, 15 Jan 2010 16:36:54 +0000 (UTC) From: "Michael Kurz (JIRA)" To: dev@myfaces.apache.org Subject: [jira] Commented: (MYFACES-2473) Make listeners added by tag handlers transient In-Reply-To: <1686975415.44521262702694542.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MYFACES-2473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800747#action_12800747 ] Michael Kurz commented on MYFACES-2473: --------------------------------------- And if serialization is the way, EventHandler.Listener should be static to make it work. > Make listeners added by tag handlers transient > ---------------------------------------------- > > Key: MYFACES-2473 > URL: https://issues.apache.org/jira/browse/MYFACES-2473 > Project: MyFaces Core > Issue Type: Bug > Components: JSR-314 > Affects Versions: 2.0.0-alpha > Reporter: Michael Kurz > Assignee: Leonardo Uribe > Fix For: 2.0.0-alpha-2 > > Attachments: MYFACES-2473.patch, MYFACES-2473_correct_style.patch > > > I had some troubles with system event listeners added by the following tag handlers: > org.apache.myfaces.view.facelets.tag.composite.InsertChildrenHandler > org.apache.myfaces.view.facelets.tag.composite.InsertFacetHandler > org.apache.myfaces.view.facelets.tag.jsf.core.EventHandler > As they are no StateHolders, are not serializable and do not have a no-argument constructor, they cause troubles with state management. The simplest solution would be to make them serializable but I think it should also be possible to make them transient as the view is rebuilt anyway on every request. This would generate no state but I'm not 100% sure if there are any side effects by making the listeners transient (it works for me and I can't think of any currently). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.