myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeanne Waldman (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TRINIDAD-1675) performance: StyleSheetDocument is called 10 times on initial render, consider caching.
Date Mon, 25 Jan 2010 21:45:34 GMT

    [ https://issues.apache.org/jira/browse/TRINIDAD-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804740#action_12804740
] 

Jeanne Waldman commented on TRINIDAD-1675:
------------------------------------------

This time I see _getStyleSheets get called 5 times on initial render with CHECK_FILE_MODIFICATION
turned off. The object it returns isn't held on to, so it's not so much a memory issue as
it is a speed issue.
1. FileSystemStyleCache (FSSC) -> _getEntry -> _getStyleSheetDocument -> getNamepspacePrefixes
-> StyleSheetDocument's (SSD) getStyleSheet

2. FSSC -> _getEntry -> _getCompatibleEntry -> _getDerivationKey -> SSD's getStyleSheets

3. FSSC -> _getEntry -> _createEntry -> _getStyleContextResolvedStyloe -> getStyles
-> _getStyleSheets

4. NameUtils -> getContextName ->getStyleSheets

5. NameUtils -> getContextName -> getDocumentId -> getStyleSheets

> performance: StyleSheetDocument is called 10 times on initial render, consider caching.
> ---------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-1675
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1675
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Skinning
>    Affects Versions:  1.2.12-core
>            Reporter: Jeanne Waldman
>
> Look into caching the style sheet per StyleContext in StyleSheetDocument's 
> public Iterator<StyleSheetNode> getStyleSheets(StyleContext context)
> because this calls _getStyleSheets which does a lot of comparing work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message