myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2475) Visit facets in UIComponent.visitTree()
Date Thu, 07 Jan 2010 16:20:54 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797670#action_12797670
] 

Jakob Korherr commented on MYFACES-2475:
----------------------------------------

I think when applying this patch, we should also change UIData.visitTree() to not visit children's
facets directly in order to visit them only once.

Although it is not explained in the spec, it is just logical to visit the component's facets
in UIComponent.visitTree(). Furthermore I don't think the EG intended that UIData's children's
facets are visited twice.

> Visit facets in UIComponent.visitTree()
> ---------------------------------------
>
>                 Key: MYFACES-2475
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2475
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Michael Kurz
>         Attachments: MYFACES-2475.patch
>
>
> I am currently trying to get f:ajax running inside a composite component. So I  would
say it is necessary to include the facets (use getFacetsAndChildren() instead of getChildren())
in UIComponent.visitTree().
> The problem with this solution is, that there is a potential conflict with UIData.visitTree()
(also see MYFACES-2137). The result is that facets of columns are visited twice. I noticed
this because UIDataTest.testVisitTree() fails unless the line expecting the column facet is
in the code twice.
> I tried the same example with Mojarra anwith the same result: the column facet is visited
twice.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message