Return-Path: 
 <dev-return-42120-apmail-myfaces-dev-archive=myfaces.apache.org@myfaces.apache.org>
Delivered-To: apmail-myfaces-dev-archive@www.apache.org
Received: (qmail 77721 invoked from network); 2 Dec 2009 10:50:45 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 2 Dec 2009 10:50:45 -0000
Received: (qmail 26427 invoked by uid 500); 2 Dec 2009 10:50:45 -0000
Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org
Received: (qmail 26347 invoked by uid 500); 2 Dec 2009 10:50:44 -0000
Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@myfaces.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@myfaces.apache.org>
List-Post: <mailto:dev@myfaces.apache.org>
List-Id: <dev.myfaces.apache.org>
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Delivered-To: mailing list dev@myfaces.apache.org
Received: (qmail 26339 invoked by uid 99); 2 Dec 2009 10:50:44 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Dec 2009 10:50:44 +0000
X-ASF-Spam-Status: No, hits=-10.5 required=5.0
	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Dec 2009 10:50:42 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id CABD4234C045
	for <dev@myfaces.apache.org>; Wed,  2 Dec 2009 02:50:21 -0800 (PST)
Message-ID: <1239414213.1259751021816.JavaMail.jira@brutus>
Date: Wed, 2 Dec 2009 10:50:21 +0000 (UTC)
From: =?utf-8?Q?Markus_D=C3=B6ring_=28JIRA=29?= <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Commented: (TRINIDAD-1327) Wrong rendering of inputFile
 inside panelFormLayout
In-Reply-To: <1691618313.1228225364364.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/TRINIDAD-1327?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1=
2784760#action_12784760 ]=20

Markus D=C3=B6ring commented on TRINIDAD-1327:
-----------------------------------------

I had a look into the issue and could at least find the cause of it.
In LabelAndMessageRenderer on Line 273 (trinidad 1.0.11 source) the RootDom=
ElementStyles get rendered, but at this point there are no open tags so the=
 class=3D"" attribute get's rendered outside of the tag.
In trinidad 1.0.7 the RootDomElementStyles where rendered on an <tr> tag th=
at was surrounding the panelFormLayout label and content cell.
An comment above the line says to me that this is not the first time that t=
his point makes trouble, and i don't want to change anything that might hav=
e side effects on other renderers extending the LabelAndMessageRenderer.
Maybe someone deeper into that code could have a look at this.
An possible workaround that works for me is changing the line into:
if(!(component instanceof CoreInputFile)) {
    renderRootDomElementStyles(context, arc, component, bean);
}
with this the InputFile get's at least rendered correctly, but it's hacky a=
nd the RootDomElementStyle is completely missing for the InputFile Componen=
t.

> Wrong rendering of inputFile inside panelFormLayout
> ---------------------------------------------------
>
>                 Key: TRINIDAD-1327
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1327
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.0.10-core
>            Reporter: Tomas Havelka
>
> The code below generates corrupted html output for inputFile component. T=
his happens just when inputFile is enclosed with panelFormLayout component =
(locale javascript are rendered in the wrong place?).
>   <f:view>
>     <tr:document>
>       <tr:form usesUpload=3D"true">
>         <tr:panelFormLayout>
>           <tr:inputFile label=3D"Input file"/>
>         </tr:panelFormLayout>
>       </tr:form>
>     </tr:document>
>   </f:view>

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.