myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeanne Waldman (JIRA)" <>
Subject [jira] Commented: (TRINIDAD-1041) Support locale-specific styles
Date Wed, 30 Dec 2009 00:38:29 GMT


Jeanne Waldman commented on TRINIDAD-1041:

A couple more comments:

I see you use LocaleUtils to create the Locale from a string.
1. Please have the code path for the XSS file format use this same method to share code. 
See StyleSheetNodeParser#_getLocale 
2. Why are you doing a '_' to '-' replace? For speed sake, don't do this, unless there is
a good use case for it.

> Support locale-specific styles
> ------------------------------
>                 Key: TRINIDAD-1041
>                 URL:
>             Project: MyFaces Trinidad
>          Issue Type: New Feature
>          Components: Skinning
>    Affects Versions: 1.0.6-core, 1.2.7-core
>            Reporter: Andy Schwartz
>            Assignee: Jeanne Waldman
>            Priority: Minor
>         Attachments: trinidad-examples-patch.patch, trinidad-impl-patch.patch
> Under the covers Trinidad still uses the legacy "XSS" style definition mechanism (eg.
see base-desktop.xss).  It would be nice to finally port  these XSS files over to CSS, since
the CSS is a far more familiar language.  However, before we can do that, we need to add a
few remaining XSS features which our not present in our CSS skinning implementation.
> One feature that we support in XSS but not in CSS is the ability to define locale-specific
styles.  In XSS, this is done via the "locales" attribute on the <styleSheet> element.
> Logging this issue to request that we add similar support to CSS skinning, with the goal
of being able to convert our XSS files over to CSS.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message