myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Markus Döring (JIRA) <...@myfaces.apache.org>
Subject [jira] Commented: (TRINIDAD-1327) Wrong rendering of inputFile inside panelFormLayout
Date Wed, 02 Dec 2009 10:50:21 GMT

    [ https://issues.apache.org/jira/browse/TRINIDAD-1327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784760#action_12784760
] 

Markus Döring commented on TRINIDAD-1327:
-----------------------------------------

I had a look into the issue and could at least find the cause of it.
In LabelAndMessageRenderer on Line 273 (trinidad 1.0.11 source) the RootDomElementStyles get
rendered, but at this point there are no open tags so the class="" attribute get's rendered
outside of the tag.
In trinidad 1.0.7 the RootDomElementStyles where rendered on an <tr> tag that was surrounding
the panelFormLayout label and content cell.
An comment above the line says to me that this is not the first time that this point makes
trouble, and i don't want to change anything that might have side effects on other renderers
extending the LabelAndMessageRenderer.
Maybe someone deeper into that code could have a look at this.
An possible workaround that works for me is changing the line into:
if(!(component instanceof CoreInputFile)) {
    renderRootDomElementStyles(context, arc, component, bean);
}
with this the InputFile get's at least rendered correctly, but it's hacky and the RootDomElementStyle
is completely missing for the InputFile Component.

> Wrong rendering of inputFile inside panelFormLayout
> ---------------------------------------------------
>
>                 Key: TRINIDAD-1327
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1327
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.0.10-core
>            Reporter: Tomas Havelka
>
> The code below generates corrupted html output for inputFile component. This happens
just when inputFile is enclosed with panelFormLayout component (locale javascript are rendered
in the wrong place?).
>   <f:view>
>     <tr:document>
>       <tr:form usesUpload="true">
>         <tr:panelFormLayout>
>           <tr:inputFile label="Input file"/>
>         </tr:panelFormLayout>
>       </tr:form>
>     </tr:document>
>   </f:view>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message