Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Received-SPF: pass (nike.apache.org: domain of andrew.rw.robinson@gmail.com
 designates 209.85.222.192 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=iyiL35/dRW+6cyowUKO6PHjzExm7KYdLCTDK24HjycqvNxfC9OaBrSEWoUNmzIUeLo
         AneL02UIs+Zb6JafY11M29nb7hyKLn1vWDGv2+nRSfgxh6Vb1h9CsIW0rBYl2JOrokWV
         onhimkL8JMeR36PDcH7BIy4JPyfAUzJc6Fg3k=
MIME-Version: 1.0
In-Reply-To: <bc36a6210911110905i7bf1d2f0u11a1c033a4a7836f@mail.gmail.com>
References: <bc36a6210911101559m7c702fc6v53aa1570874daaa5@mail.gmail.com>
	 <bc36a6210911110905i7bf1d2f0u11a1c033a4a7836f@mail.gmail.com>
Date: Wed, 11 Nov 2009 10:16:43 -0700
Message-ID: <bc36a6210911110916m32f72a1bs3117880141135da1@mail.gmail.com>
Subject: Re: [Trinidad] Okay to deprecate ComponentUtils.findRelativeComponent
	and move the code under the control of UIXComponent?
From: Andrew Robinson <andrew.rw.robinson@gmail.com>
To: MyFaces Development <dev@myfaces.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

Note that the deprecated syntax was done as part of
https://issues.apache.org/jira/browse/TRINIDAD-757

So it has been deprecated since Oct 2007

-Andrew

On Wed, Nov 11, 2009 at 10:05 AM, Andrew Robinson
<andrew.rw.robinson@gmail.com> wrote:
> Added a JIRA issue for this: TRINIDAD-1633
>
> In addition to just moving it I would like to remove the support for
> the deprecated syntax that we have been keeping around as it would not
> fit as nicely. This deprecated syntax was the one in which the "::"
> was not necessary to search in the parent naming container from a
> naming container. It did not match the paradigm for the findComponent
> API, so we changed it a couple of years back or so. I think that this
> is adequate time to have migrated the projects over, but please let me
> know if there are any strong objects to removing this support.
>
> Thanks,
> Andrew
>
> On Tue, Nov 10, 2009 at 4:59 PM, Andrew Robinson
> <andrew.rw.robinson@gmail.com> wrote:
>> With looking forward to JSF2 and the composite component design, there
>> are some instances where we may want to control how the "::" gets
>> resolved at the component level. This would be useful for relocated
>> facets so that the user's original "::" would be correctly interpreted
>> from the original page location.
>>
>> What I would like to do is to move the code from
>> ComponentUtils.findRelativeComponent to UIXComponent as a static
>> public method "public static String findComponent(UIComponent
>> component, String id)". Then UIXComponent would also provide built in
>> support for "::" in the findComponent instance method. The reason for
>> the static method is so the UIXComponent.findComponent could be used
>> to achieve the relative (::) find strings to use with non-UIXComponent
>> components. The implementation would be to have UIXComponent handle
>> the resolution of the colons in the static method for UIComponent
>> instances, and delegate the code to the instance method for
>> UIXComponent instances. Basically, the same design pattern as the code
>> I added to UIXComponent for the addPartialTarget method.
>>
>> ComponentUtils.findRelativeComponent would be then deprecated and
>> simply call UIXComponent.findComponent (static).
>>
>> Are there any objections to this change?
>>
>> Thank you,
>> Andrew
>>
>