myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Korherr (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-2374) UIViewRoot.getBeforePhaseListener() and UIViewRoot.getAfterPhaseListener() could be called on PhaseId.RESTORE_VIEW
Date Fri, 23 Oct 2009 10:23:59 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769164#action_12769164
] 

Jakob Korherr commented on MYFACES-2374:
----------------------------------------

Leonardo just found out the official statement about this at http://wiki.java.net/bin/view/Projects/Jsf2MR1ChangeLog.

C015 	 Errata 	 UIViewRoot?.setBeforePhaseListeners() removed the statement that all phases
including RestoreView? will have their beforePhaseListeners called. Reverted to the way it
was in 1.2 

But this means that we still have to call UIViewRoot.getAfterPhaseListener() after RESTORE_VIEW,
right?
And what about the phaselisteners of getPhaseListeners(). Should they also only be called
for after restore view? This would not make much sence, because the spec says that no afterPhase
method should be invoked without a clean run of beforePhase before.

So I think the right thing to do is to only call UIViewRoot.getAfterPhaseListener() after
RESTORE_VIEW.

Any other opinions?

> UIViewRoot.getBeforePhaseListener() and UIViewRoot.getAfterPhaseListener() could be called
on PhaseId.RESTORE_VIEW
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2374
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2374
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>            Reporter: Leonardo Uribe
>         Attachments: restore_view_phaselistener.patch
>
>
> Note that on jsf 1.2 this is not true. The problem with this one is how call UIViewRoot
beforePhaseListener before PhaseId.RESTORE_VIEW, because in theory we need to "restore it"
before call it. Maybe the solution is call it from the place where the state is restored (JspStateManagerImpl).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message