Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <891247673.1253763005336.JavaMail.jira@brutus>
Date: Wed, 23 Sep 2009 20:30:05 -0700 (PDT)
From: "Leonardo Uribe (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Commented: (MYFACES-2137) JSF 2.0 Component Tree Visiting
In-Reply-To: <5059107.1232493601669.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/MYFACES-2137?page=3Dcom.atlassi=
an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12=
758990#action_12758990 ]=20

Leonardo Uribe commented on MYFACES-2137:
-----------------------------------------

I have some comments about the patch:

- We need to traverse facets and facets inside child components only once. =
Take a look at UIData.invokeOnComponent, you will see that facets are trave=
rse only once with rowIndex=3D-1 (no row selected)
- Spec says: "Let rowsToProcess be the return from getRows().", but a resul=
t of 0 from getRows() means all rows. In that case should rowsToProcess be =
getRowCount()? No.  The difference is that getRows() means the max rows to =
be displayed. That is because it is not necessary to traverse all rows when=
 we only expect to traverse the rows we are going to display. note that we =
call isRowAvailable() to check if the row exists or not.
- Spec says: "Let rowIndex be the return from getFirst() - 1.", but then yo=
u would start the iteration with a rowIndex of -1 (if getFirst() returns 0)=
 and you would end one row to early. For example you have 3 rows 0, 1 and 2=
, so visitTree would visit the rows -1, 0 and 1. So why should we start at =
getFirst() - 1? The intention is traverse all rows that exists. Maybe this =
is a detail on the algorithm used by ri, so we can ignore this part while w=
e maintain the intention of the algorithm (but see comment below).
- Note that UIColum instances should be traverse only once (with rowIndex=
=3D-1), because traverse them per row just does not have sense. Also in my =
opinion, does not have sense how the algorithm works with facets of childre=
n component. Maybe it is a good idea to send a mail to jsr-314-comments at =
jcp.org saying this javadoc is not very clear (specially the last two point=
s).


> JSF 2.0 Component Tree Visiting
> -------------------------------
>
>                 Key: MYFACES-2137
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2137
>             Project: MyFaces Core
>          Issue Type: New Feature
>          Components: JSR-314
>    Affects Versions: 2.0.0-alpha
>            Reporter: Matthias We=C3=9Fendorf
>         Attachments: uidata_visit_tree.patch
>
>
> The Tree Visiting, part of jsf2.0, was already added to Trinidad 1.2.x to=
 improve things.=20
> We just need to add the api/impl from that patch, to this project.
> see TRINIDAD-1368 for more.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.