myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Griffin (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (PORTLETBRIDGE-77) Add detection of Servlet API dependencies in JSF implementation
Date Mon, 08 Jun 2009 15:18:07 GMT

    [ https://issues.apache.org/jira/browse/PORTLETBRIDGE-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717289#action_12717289
] 

Neil Griffin commented on PORTLETBRIDGE-77:
-------------------------------------------

I too searched *.xml *.java and *.jsp for occurrences of "/invoke" and couldn't find any.

So I don't know the answer to your question, but I have a guess...

Section PLT.19.3.1 of the Portlet 2.0 spec says that the following parameters must be set:

javax.servlet.include.request_uri
javax.servlet.include.context_path
javax.servlet.include.servlet_path
javax.servlet.include.path_info
javax.servlet.include.query_string

So it might be that Liferay sets a value to "/invoke", simply to pass the TCK test suite,
thus achieving compliance.

> Add detection of Servlet API dependencies in JSF implementation
> ---------------------------------------------------------------
>
>                 Key: PORTLETBRIDGE-77
>                 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-77
>             Project: MyFaces Portlet Bridge
>          Issue Type: Improvement
>            Reporter: Neil Griffin
>         Attachments: FacesUtil.java, PortletExternalContextImpl.java
>
>
> This issue was discovered when trying to use the JSR 301 RI with Liferay Portal.
> The Portlet spec requires the implementing portlet container (in this case, specifically
Liferay Portal) to specify the following request attributes:
> 	javax.servlet.include.path_info
> 	javax.servlet.include.servlet_path
> Mojarra 1.2_12 is trying to determine the viewId by checking the values of these attributes.
I would consider this to be a Servlet API dependency (or assumption) by Mojarra. Liferay Portal
is supplying its own internal values for these attributes, which have no JSF viewId meaning
to Mojarra. I submitted patches to Sun, which will appear in Mojarra 1.2_13 when it is released.
Until then, the patch appears in nightly snapshots.
> The JSR 301 RI is aware of these servlet dependency problems in Mojarra, and contains
some workarounds. This ticket describes an improvement that needs to be made to the JSR 301
RI, such that it will add detection of Servlet API dependencies in the JSF implementation,
and only perform the workarounds if those dependencies are found.
> I'll attach patches to this ticket shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message