myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthias Weßendorf (JIRA) <...@myfaces.apache.org>
Subject [jira] Commented: (TRINIDAD-1390) maximumLength generates onKeyUp JavaScript even if value is <= 0
Date Tue, 17 Feb 2009 13:02:59 GMT

    [ https://issues.apache.org/jira/browse/TRINIDAD-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674204#action_12674204
] 

Matthias Weßendorf commented on TRINIDAD-1390:
----------------------------------------------

and

  @Override
  protected String getOnchange(
    FacesBean bean
    )
  {
    String onchange = super.getOnchange(bean);
    if (isAutoSubmit(bean))
    {
      RenderingContext arc = RenderingContext.getCurrentInstance();
      String source = LabelAndMessageRenderer.__getCachedClientId(arc);
      boolean immediate = isImmediate(bean);
      String auto = AutoSubmitUtils.getSubmitScript(arc, source, XhtmlConstants.AUTOSUBMIT_EVENT,
immediate);
      if (onchange == null)
        onchange = auto;
      else if (auto != null)
        onchange = XhtmlUtils.getChainedJS(onchange, auto, true);
    }

    if (isTextArea(bean))
    {
      Number maxLength = getMaximumLength(bean);
      if (maxLength != null && maxLength.intValue()> 0)
      {
        onchange = _getMaxLengthFunction(onchange,
                                         maxLength.intValue());
      }
    }

    return onchange;
  }

> maximumLength generates onKeyUp JavaScript even if value is <= 0
> ----------------------------------------------------------------
>
>                 Key: TRINIDAD-1390
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1390
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.10-core
>         Environment: Facelets 1.1.14, MyFaces core 1.2.4, Glassfish v2
>            Reporter: Bart Kummel
>            Assignee: Matthias Weßendorf
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When "columns" is set to a value > 1 on an tr:inputText, a textarea is rendered instead
of an ordinary input. Since a textarea doesn't support the "maxlength" attribute, a JavaScript
function is used to force the maximum input length if the "maximumLength" attrinute is used
on the component. The value of "maximumLength" is used as a parameter for the JavaScript function.
If this value is <= 0, this means no text can be typed in the textarea, the JavaScript
function will prevent this. But according to the documentation, setting "maximumLength" to
a value <= 0 should disable maximum length checking. If the "maximumLength" is not set
at all, no JavaScript function call is added to the textarea. This should also happen if the
value of "maximumLength" <= 0.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message