myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Kitching (JIRA)" <>
Subject [jira] Commented: (MYFACES-1963) <script src=""> generates extra html comments
Date Wed, 10 Sep 2008 07:34:46 GMT


Simon Kitching commented on MYFACES-1963:

It might be time to just get rid of these comment characters completely.

They are only there to support browsers that are too old to recognise a <script> tag,
right? I doubt very much that any such browsers are in use any more. Even simple browsers
such as lynx should *recognise* the tag and handle it correctly, even if they ignore the content.

Getting rid of these comments would make pages smaller and look much nicer..

> <script src=""> generates extra html comments
> ---------------------------------------------
>                 Key: MYFACES-1963
>                 URL:
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 1.1.3, 1.1.4, 1.1.5
>            Reporter: Bruno Hondelatte
>            Priority: Minor
> When inserting a javascript source file, extra comments are added. For instance :
> <script type="text/javascript" src="test.js"><!-- --> </script>
> A way to remove these comments would be to generate comments inside write and writeText
methods in org.apache.myfaces.shared.renderkit.html.HtmlResponseWriterImpl, and not in writeElement
method. In this case, if no write or writeElement is issued, the unnecessary comments are
not written to the output.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message