myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Rivera (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TOMAHAWK-1183) inputCalendar setfocus not working
Date Tue, 02 Sep 2008 13:13:44 GMT

    [ https://issues.apache.org/jira/browse/TOMAHAWK-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627662#action_12627662
] 

Paul Rivera commented on TOMAHAWK-1183:
---------------------------------------

Hmm...

Looking back at this line:
In HtmlTextHelpRenderer.renderHelpTextAttributes() L123:
HtmlRendererUtils.renderHTMLAttributes(writer, component, HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK);


It seems strange that in tomahawk12, the INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK
array contains 'onfocus'.  Its variable name says that it should not have disabled, onfocus
and onclick.

I think the original intent of the code for rendering HtmlInputTextHelp was to have only one
handler for onfocus and one handler for onclick.  Any handlers for onfocus and onclick supplied
by the user are discarded.  Here's the code block:
                HtmlRendererUtils.renderHTMLAttributes(writer, component,
                                                       HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK);
                writer.writeAttribute(HTML.ONFOCUS_ATTR,
                                      HtmlInputTextHelp.JS_FUNCTION_SELECT_TEXT + "('" +
                                      getHelpText(component) + "', '" + id +"')", null);
                writer.writeAttribute(HTML.ONCLICK_ATTR,
                                      HtmlInputTextHelp.JS_FUNCTION_SELECT_TEXT + "('" +
                                      getHelpText(component) + "', '" + id +"')", null);
It specifically uses a string array that doesn't contain onfocus and onclick.  This is why
both onfocus and onclick do not work in inputCalendar of tomahawk 1.1.6.

Onclick also doesn't work for inputCalendar of tomahawk12.  Although, onfocus does work in
inputCalendar of tomahawk12.  This is the inconsistency.

EVENT_HANDLER_ATTRIBUTES_WITHOUT_ONCLICK does affect a couple of other components.  I'll have
to look into this some more.

> inputCalendar setfocus not working
> ----------------------------------
>
>                 Key: TOMAHAWK-1183
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1183
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.6
>         Environment: windows xp
>            Reporter: richard lee
>         Attachments: tomahawk-1183.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The inputCalendar tag / component is not rendering javascript entered for the setfocus
property. I'm attempting to add some custom javascript to the setfocus of an inputcalendar
to be run when the user clicks in the input box associated with the calendar, but this is
being ignored during the redering of the input box. The only javascript that gets rendered
is the "standard" javascript , i.e. onfocus="selectText('null', 'con9n')".
> I believe the issue is in HtmlTextHelpRenderer:
> if(isSelectText(component))
>             {
>                 HtmlRendererUtils.renderHTMLAttributes(writer, component,
>                                                        HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK);
>                 writer.writeAttribute(HTML.ONFOCUS_ATTR,
>                                       HtmlInputTextHelp.JS_FUNCTION_SELECT_TEXT + "('"
+
>                                       getHelpText(component) + "', '" + id +"')", null);
>                 writer.writeAttribute(HTML.ONCLICK_ATTR,
>                                       HtmlInputTextHelp.JS_FUNCTION_SELECT_TEXT + "('"
+
>                                       getHelpText(component) + "', '" + id +"')", null);
>             }
> when writing out the HTML.ONFOCUS_ATTR is should write out any user specified onfocus
attributes as well as the standard ones.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message