Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <1681240385.1218063524564.JavaMail.jira@brutus>
Date: Wed, 6 Aug 2008 15:58:44 -0700 (PDT)
From: =?utf-8?Q?Simon-Pierre_B=C3=A9liveau_=28JIRA=29?=
 <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Updated: (MYFACES-1897) escape value of a selectItem is
 never evaluated
In-Reply-To: <72148736.1216033292875.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/MYFACES-1897?page=3Dcom.atlass=
ian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simon-Pierre B=C3=A9liveau updated MYFACES-1897:
-------------------------------------------

    Status: Patch Available  (was: Open)

> escape value of a selectItem is never evaluated
> -----------------------------------------------
>
>                 Key: MYFACES-1897
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1897
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-252
>    Affects Versions: 1.2.3
>            Reporter: J=C3=B6rg Rothbarth
>            Assignee: Leonardo Uribe
>         Attachments: myfaces-1897.patch, SelectItemEscapeBean.java, selec=
tOneManyEscape.jsp
>
>
> The escape Attribute of a selectItem Component is not evaluated inside a =
selectOneRadio component.
> The selectItem Component has a escape member, but the member is never use=
d.=20
> To fix the problem i've done this:
> HtmlRadioRendererBase.renderGroupOrItemRadio() Line ~199 :
> // label element after the input
> boolean componentDisabled =3D isDisabled(facesContext, selectOne);
> boolean disabled =3D (componentDisabled || itemDisabled);
> boolean escape =3D selectItem.isEscape();
> HtmlRendererUtils.renderLabel(writer, selectOne, itemId,
>                 selectItem.getLabel(), disabled,escape);
> HtmlRendererUtils.renderLabel() Line ~1352:
> public static void renderLabel(ResponseWriter writer, UIComponent   =20
>     component, String forClientId,String labelValue, boolean   =20
>                 disabled) throws IOException {
> renderLabel(writer, component, forClientId, labelValue, disabled, true);
> }
> /**
>  * Renders a label HTML element
>  */
> public static void renderLabel(ResponseWriter writer, UIComponent
>             component, String forClientId,String labelValue,         bool=
ean disabled, boolean escape) throws IOException {
> ...
> if ((labelValue !=3D null) && (labelValue.length() > 0)) {
>     writer.write(HTML.NBSP_ENTITY);
>     if (escape) {
>         writer.writeText(labelValue, null);
>     } else {
>         writer.write(labelValue);
>     }
> }
> ...=20

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.