Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <1324945060.1219857584620.JavaMail.jira@brutus>
Date: Wed, 27 Aug 2008 10:19:44 -0700 (PDT)
From: "Jeanne Waldman (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Commented: (TRINIDAD-205) Need to avoid IE's number of CSS
 selectors limitation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/TRINIDAD-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626194#action_12626194 ] 

Jeanne Waldman commented on TRINIDAD-205:
-----------------------------------------

I looked at the code briefly and it looks like it would work. However, I think the implementation I mentioned in my note above is cleaner. Blake and I discussed some approaches together and this is the one we felt was cleanest because it kept the knowledge of the file limitations to the writeCSS code. What do you think? 

> Need to avoid IE's number of CSS selectors limitation
> -----------------------------------------------------
>
>                 Key: TRINIDAD-205
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-205
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.0.1-incubating-core-SNAPSHOT
>            Reporter: Jeanne Waldman
>            Assignee: Simon Lessard
>         Attachments: TRINIDAD-205.patch
>
>
> it turns out that IE has a limit to the size of a CSS file. It's not the actual size of the file, but rather it is the
> # of CSS selectors. I did a test and found out that the limit is 4095 CSS selectors.
> Firefox doesn't appear to have a limit.
> As you may know, the CSS file we generate contains both compressed and uncompressed styles, like this:
> .af_inputText_content, .x01 {background-color: blue}
> Our renderers render a shortened styleclass, unless
> the DISABLE_CONTENT_COMPRESSION flag is set to true in web.xml, then it renders the long styleclass.
> <input class="x01...>
> Ok, that's the background.
> *The problem* is that because we have a lot of custom components that we've built on top of Trinidad, and our customers
> have built custom components, etc, and these all have skinning,
> we have bumped up against the 4095 selector limit in IE. All selectors after the 4095th one are ignored.
> *A quick fix*, and probably a good one for a long time, is to render the styles in compressed mode when compression is on,
> or in uncompressed mode when compression if off. That will reduce our style selectors by 1/2, and will help performance to boot. :)
> I can also add a warning if we go past 4095 selectors for IE.
> Another solution is to break up the file into multiple files when I've reached the limit in one file, and include
> all the css files into the rendered page. I can do this in addition to the quick fix when I have more time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.