myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-1832) bad charset encoding on <f:param> tag
Date Thu, 07 Aug 2008 00:12:44 GMT

    [ https://issues.apache.org/jira/browse/MYFACES-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620484#action_12620484
] 

Leonardo Uribe commented on MYFACES-1832:
-----------------------------------------


The problem with this issue is the params are encoded twice:

1 When is first processed on HtmlLinkRendererBase.addChildParameters
2. When is written the onclick attribute using writer.writeAttribute.

 The strange part is what jsf ri api says about the behavior of f:param (on h:commandLink):

"....The name and the value(for UIParam children) must be URLEncoded..."

but on h:outputLink says this:

"....... The name of the UIParameter goes on the left hand side, and the value of the UIParameter
on the right hand side. The name and the value must be URLEncoded....."

But for render parameters for h:outputLink it is used URLEncoder.encode (right), but on h:commandLink
it is not used (why if the api doc says the same). 

The problem about how to solve this issue is if we have to use URLEncoder.encode (as the doc
says) or just do no encoding (but letting writer.writeAttribute encode it). 


> bad charset encoding on <f:param> tag
> -------------------------------------
>
>                 Key: MYFACES-1832
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1832
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 1.1.5,  1.2.0, 1.2.2
>         Environment: myfaces 1.1.5 
>            Reporter: Luca Stancapiano
>             Fix For:  1.1.6-SNAPSHOT, 1.1.6
>
>
> there is a bug into myfaces 1.1.5 and up..... 
> on a page as it:
> <h:form>                                                                      
     
>                  <h:commandLink action="#{Action.execute}">
>                     <h:outputText value="some"/>
>                     <f:param name="id" value="#{instance.id}"/>
>                  </h:commandLink>
> </h:form> 
> using <f:param name="id" value="#{instance.id}"> tag inside <h:commandLink>
, I see that instance.id value has a bad encoding... if I use a word with special characters
as à, è, ù, ì as instance.id for example 'modalità' , it is encoded into 'modalit&amp;#224'
instead of 'modalit&agrave' . When I click on link through command link, that id cannot
to be decoded and so cannot to work with the real value ofinstance.id

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message