Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 9833 invoked from network); 31 Jul 2008 18:39:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 31 Jul 2008 18:39:17 -0000 Received: (qmail 4859 invoked by uid 500); 31 Jul 2008 18:39:15 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 4815 invoked by uid 500); 31 Jul 2008 18:39:15 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 4804 invoked by uid 99); 31 Jul 2008 18:39:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Jul 2008 11:39:15 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [213.46.255.22] (HELO viefep15-int.chello.at) (213.46.255.22) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 31 Jul 2008 18:38:19 +0000 Received: from edge01.upc.biz ([192.168.13.236]) by viefep15-int.chello.at (InterMail vM.7.08.02.00 201-2186-121-20061213) with ESMTP id <20080731183832.PBIE14014.viefep15-int.chello.at@edge01.upc.biz> for ; Thu, 31 Jul 2008 20:38:32 +0200 Received: from [192.168.1.101] ([84.113.196.60]) by edge01.upc.biz with edge01 id wieX1Z02j1JfwPo01ieY0o; Thu, 31 Jul 2008 20:38:32 +0200 X-SourceIP: 84.113.196.60 Subject: Re: svn commit: r681431 [1/3] - in /myfaces/extensions/validator/branches/trunk_layout_myfaces/validation-modules: ./ property-validation/ property-validation/src/main/java/org/apache/myfaces/extensions/validator/ property-validation/src/main/java/org/apac... From: simon To: MyFaces Development In-Reply-To: <20080731182754.BDDC8238889B@eris.apache.org> References: <20080731182754.BDDC8238889B@eris.apache.org> Content-Type: text/plain Date: Thu, 31 Jul 2008 20:38:31 +0200 Message-Id: <1217529511.6267.7.camel@simon-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Hi Leonardo, On Thu, 2008-07-31 at 18:27 +0000, lu4242@apache.org wrote: > Author: lu4242 > Date: Thu Jul 31 11:27:50 2008 > New Revision: 681431 > > URL: http://svn.apache.org/viewvc?rev=681431&view=rev > Log: > apply checkstyle rules Just about these license changes: As I noted in an earlier email (you might have been on holiday), there are for historical reasons two different copyright header layouts currently in use in myfaces code. One has " * some text" and the other has " * some text" (one more space). The approach I have taken is to publish two possible templates to check against in the checkstyle-rules module, so that each project can use the template that matches the majority of the existing code. That minimises the number of files that need to be changed; a project has to be internally consistent but can choose either layout. The two templates are named "myfaces-header.txt" and "myfaces-header-spaces.txt". Personally, I prefer the one-space version (myfaces-header.txt) as that matches what all the commons.apache.org projects use. But I can't see any official version anywhere, so I guess both are valid. Just thought I would point that out in case you weren't aware of it... Regards, Simon