myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Heinen (JIRA)" <...@myfaces.apache.org>
Subject [jira] Issue Comment Edited: (TOMAHAWK-1301) render ids of radio buttons
Date Fri, 18 Jul 2008 12:28:31 GMT

    [ https://issues.apache.org/jira/browse/TOMAHAWK-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614710#action_12614710
] 

mheinen edited comment on TOMAHAWK-1301 at 7/18/08 5:28 AM:
-------------------------------------------------------------------

The changes worked locally for me with tomahawk 1.1.5.
But I was not able to create a patch because of the unfamiliar project structure.
I am not sure about java files in target folders. Those cannot be added into a patch.
Therefore I added them manually but I think this will not work this way ...

Class org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRadioRendererBase is in the shared_tomahawk
project which does not have access to classes in tomahawk project e.g. to org.apache.myfaces.component.html.ext.HtmlSelectOneRadio.
I found org.apache.myfaces.component.html.ext.HtmlSelectOneRadio only in a folder called tomahawk/target/myfaces-builder-plugin/main/java.
So where can I patch this class ?
Class org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRadioRendererBase is also in a
target folder, namely  tomahawk/target/shared_sources.
Moreover I was not able to add a entity for tomahawk.tld to the patch.

I added all these files separately into the zip file.


Could someone explain these problems and the project structure to me?
Is there any documentation available?


      was (Author: mheinen):
    The changes worked locally for me with tomahawk 1.1.5.
But I was not able to create a patch because of the unfamiliar project structure.
I am not sure about java files in target folders. Those cannot be added into a patch.
Therefore I added them manually but I think this will not work this way ...

Class org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRadioRendererBase is in the shared_tomahawk
project which does not have access to classes in tomahawk project e.g. to org.apache.myfaces.component.html.ext.HtmlSelectOneRadio.
I found org.apache.myfaces.component.html.ext.HtmlSelectOneRadio only in a folder called tomahawk/target/myfaces-builder-plugin/main/java.
So where can I patch this class ?
Class org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRadioRendererBase is also in a
target folder, namely  tomahawk/target/shared_sources.
Moreover I was to able to add a entity for the tomahawk.tld to the patch.

I added all these files separately into the zip file.


Could someone explain these problems and the project structure to me?
Is there any documentation available?

  
> render ids of radio buttons
> ---------------------------
>
>                 Key: TOMAHAWK-1301
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1301
>             Project: MyFaces Tomahawk
>          Issue Type: Improvement
>          Components: selectOneRadio / radio
>            Reporter: Michael Heinen
>         Attachments: 1301.zip
>
>
> I miss the id attribute in radio buttons (input tags) rendered via t:selectOneRadio.
> This is required in order for easier javascript access and for better accessibility during
Selenium testing.
> Therefore I request an additional boolean attribute renderChildIds.
> The index of the radio buttons should be rendered in brackets, e.g. myform:mybutton[0]
- myform:mybutton[n]
> I'll try to provide a patch

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message