myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TOMAHAWK-1301) render ids of radio buttons
Date Wed, 30 Jul 2008 20:51:32 GMT

    [ https://issues.apache.org/jira/browse/TOMAHAWK-1301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618502#action_12618502
] 

Leonardo Uribe commented on TOMAHAWK-1301:
------------------------------------------

this is a duplicate of TOMAHAWK-1295.

On tomahawk core12, this problem is not present, since there was changes on jsf 1.2 spec that
causes the id rendered is like this:

clientIdOfComponent:index

so the solution should pass from this:

jsf

        <t:selectOneRadio id="set2" layout="spread">
            <f:selectItem itemValue="0"
                itemLabel="group 0" />
            <f:selectItem itemValue="1"
                itemLabel="group 1" />
            <f:selectItem itemValue="2"
                itemLabel="group 2" />
        </t:selectOneRadio>
        <t:radio for="set2" index="0" />
        <t:radio for="set2" index="1" />
        <t:radio for="set2" index="2" />

html

<label><input type="radio" name="_idJsp0:set2" value="0" />&#160;group 0</label>
<label><input type="radio" name="_idJsp0:set2" value="1" />&#160;group 1</label>
<label><input type="radio" name="_idJsp0:set2" value="2" />&#160;group 2</label>

to this:

<label><input id="_idJsp0:set2:0" type="radio" name="_idJsp0:set2" value="0" />&#160;group
0</label>
<label><input id="_idJsp0:set2:1" type="radio" name="_idJsp0:set2" value="1" />&#160;group
1</label>
<label><input id="_idJsp0:set2:2" type="radio" name="_idJsp0:set2" value="2" />&#160;group
2</label>

If a change is done on tomahawk core 1.1, it should be the same as presented here, so I'll
fix it in this way.

thanks for the suggestions.

> render ids of radio buttons
> ---------------------------
>
>                 Key: TOMAHAWK-1301
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1301
>             Project: MyFaces Tomahawk
>          Issue Type: Improvement
>          Components: selectOneRadio / radio
>            Reporter: Michael Heinen
>            Assignee: Leonardo Uribe
>         Attachments: 1301.zip
>
>
> I miss the id attribute in radio buttons (input tags) rendered via t:selectOneRadio.
> This is required in order for easier javascript access and for better accessibility during
Selenium testing.
> Therefore I request an additional boolean attribute renderChildIds.
> The index of the radio buttons should be rendered in brackets, e.g. myform:mybutton[0]
- myform:mybutton[n]
> I'll try to provide a patch

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message