Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 25764 invoked from network); 16 Jun 2008 17:58:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Jun 2008 17:58:50 -0000 Received: (qmail 95242 invoked by uid 500); 16 Jun 2008 17:58:51 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 95196 invoked by uid 500); 16 Jun 2008 17:58:51 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 95185 invoked by uid 99); 16 Jun 2008 17:58:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jun 2008 10:58:51 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Jun 2008 17:58:01 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 0A1BD234C142 for ; Mon, 16 Jun 2008 10:57:45 -0700 (PDT) Message-ID: <1879685450.1213639065040.JavaMail.jira@brutus> Date: Mon, 16 Jun 2008 10:57:45 -0700 (PDT) From: "Leonardo Uribe (JIRA)" To: dev@myfaces.apache.org Subject: [jira] Commented: (TOMAHAWK-449) URL Validator does not accept simple web addresses In-Reply-To: <30665968.1148562330757.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TOMAHAWK-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605362#action_12605362 ] Leonardo Uribe commented on TOMAHAWK-449: ----------------------------------------- Remembering the suggestions: [1] add allowed protocol to validator tag (http, httpd, ftp) [2] require/not require protocol [3] requrie/not require port [4] validate a TLD without web resource (eg www.mytld.com) After checking the suggestions, commons validator UrlValidator class allows only [1]. The other suggestions are still valid, but in my opinion, the best is use a custom validator, because the intention of this validator is validate if a url is valid or not, the suggestions [2], [3] are very specific extensions, and option [4] is not a valid url after all. I'll implement option [1] and close this issue. > URL Validator does not accept simple web addresses > -------------------------------------------------- > > Key: TOMAHAWK-449 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-449 > Project: MyFaces Tomahawk > Issue Type: Improvement > Components: Validators > Environment: All > Reporter: Julian Ray > Priority: Minor > > the sandbox URL validator uses the Apache Commons GenericValidator component which disallows simple web addresses such as www.mytld.com. The current version requires www.mytld.com/somepage > Suggest improving the validator to > [1] add allowed protocol to validator tag (http, httpd, ftp) > [2] require/not require protocol > [3] requrie/not require port > [4] validate a TLD without web resource (eg www.mytld.com) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.