myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TOMAHAWK-1266) t:stylesheet renders link to an empty page on tomcat-5.5.24 and above
Date Mon, 23 Jun 2008 17:04:45 GMT

    [ https://issues.apache.org/jira/browse/TOMAHAWK-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607294#action_12607294
] 

Leonardo Uribe commented on TOMAHAWK-1266:
------------------------------------------

The patch causes an error on the test:

-------------------------------------------------------------------------------
Test set: org.apache.myfaces.custom.stylesheet.StylesheetRendererTest
-------------------------------------------------------------------------------
Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.031 sec <<< FAILURE!
testInline(org.apache.myfaces.custom.stylesheet.StylesheetRendererTest)  Time elapsed: 0.016
sec  <<< ERROR!
javax.faces.FacesException: Exception while calling encodeEnd on : {Component-Path : [Class:
org.apache.myfaces.custom.stylesheet.Stylesheet,Id: null]}
	at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:765)
	at org.apache.myfaces.custom.stylesheet.StylesheetRendererTest.testInline(StylesheetRendererTest.java:74)
Caused by: javax.faces.FacesException: Inline stylesheets require absolute resource path
	at org.apache.myfaces.custom.stylesheet.StylesheetRenderer.encodeEnd(StylesheetRenderer.java:63)
	at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:762)
	... 26 more

I agree that the best is do something like on the patch, but the test needs to be corrected.
I'll try correct the test and probe the
example on myfaces-example-simple

> t:stylesheet renders link to an empty page on tomcat-5.5.24 and above
> ---------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1266
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1266
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Stylesheet
>    Affects Versions: 1.1.5
>         Environment: linux, tomcat, myfaces-1.1.5, tomahawk-1.1.5
>            Reporter: Ronald Müller
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.7-SNAPSHOT
>
>         Attachments: stylesheet-patch.txt, StyleTest.war
>
>
> on tomcat-5.5.24 and above (also 6.0.x)  t:stylesheet with filter-attribute set to 'true'
renders a style-link that links to an empty page. without filtering everything works fine
since t:stylesheet renders direct links to the css-files (not using the extension-filter).
> maybe this issue is related to the extension filter or it is a tomcat-issue only. since
it definitely happens first time with tomcat-version 5.5.24. (5.0.x-5.5.23 working fine).
> i'll provide a minimal test-case as war-file. just deploy and request 'http://localhost:8080/StyleTest/styletest.faces'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message