Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 2187 invoked from network); 16 May 2008 16:54:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 May 2008 16:54:27 -0000 Received: (qmail 48723 invoked by uid 500); 16 May 2008 16:54:27 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 48681 invoked by uid 500); 16 May 2008 16:54:27 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 48670 invoked by uid 99); 16 May 2008 16:54:27 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 May 2008 09:54:27 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 May 2008 16:53:40 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A4B9A234C114 for ; Fri, 16 May 2008 09:53:55 -0700 (PDT) Message-ID: <1873202000.1210956835673.JavaMail.jira@brutus> Date: Fri, 16 May 2008 09:53:55 -0700 (PDT) From: "Andrew Robinson (JIRA)" To: dev@myfaces.apache.org Subject: [jira] Commented: (TRINIDAD-89) Server side CSS constants for .css files In-Reply-To: <19409575.1183668724835.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TRINIDAD-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597547#action_12597547 ] Andrew Robinson commented on TRINIDAD-89: ----------------------------------------- If this were implemented as in the patch, I personally would prefer to see a more obvious way to note that the value is a constant (some syntax like ${constant.name}) > Server side CSS constants for .css files > ---------------------------------------- > > Key: TRINIDAD-89 > URL: https://issues.apache.org/jira/browse/TRINIDAD-89 > Project: MyFaces Trinidad > Issue Type: Improvement > Components: Skinning > Affects Versions: 1.0.2-core > Reporter: Leonardo Uribe > Attachments: patchConstants6.patch > > > Working in my Google Summer of Code, I have found that It would be cool, when you define a css skin file that you can do something like this: > @constants { > greencolor: #97f099; > f90color : #f90; > } > .AFPanelNavigationHorizontal ul li.off a:hover, .AFPanelNavigationHorizontal ul li:hover a, .AFPanelNavigationHorizontal ul li.over a { > background: greencolor; > color: f90color; > } > Like in server side CSS in PHP. > I have created a patch that adds this feature. With this, yo can define local constants variables in a .css file that is used as trinidad skin file. > (If you define a constant in a base skin, the extended skins don't see it). It's a simple but powerful idea. > Suggestion for improvements of this topic are welcome. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.