myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott O'Bryan" <darkar...@gmail.com>
Subject Re: [VOTE] Release of Trinidad 1.2.8
Date Tue, 20 May 2008 09:02:33 GMT
Ok Paul, TRINIDAD-1083 has been applied to both trunks, the 1.0.8 label 
and the 1.2.8 label.  All of the artifacts have been regenerated.

When you test it, give me your +1 and I think we're ready to release.

Scott

Scott O'Bryan wrote:
> Cool, thanks Matthias.  I'm currently regenerating the artifacts for 
> 1.2.8 and 1.0.8.  They should be up in about an hour.
>
> Download from home is fast, but upload it REALLY SLOW..
>
> Scott
>
> Matthias Wessendorf wrote:
>> Hi,
>>
>> We need 3 +1 votes. 2.5 is not enough. Sounds like we need to wait 
>> for the 1.2.8 fix...
>>
>> Sent from my iPod.
>>
>> Am 20.05.2008 um 02:05 schrieb "Scott O'Bryan" <darkarena@gmail.com>:
>>
>>> Venkata, we'll need a JIRA issue and a patch if possible.  I can 
>>> apply it asap.
>>>
>>> To the community, I do have a question..   Concerning this vote we 
>>> had 2.5 +1's and 1 -1.  Technically I think that allows us to 
>>> release but I suspect people would want to get this one fixed 
>>> first.  I'll allow people to chime in as needed on both this and the 
>>> 1.0.8 thread if you'd like to stop the release.  Once Venkata 
>>> submits the patch, I can certainly apply it and generate the 
>>> artifacts, but it will delay our release another 72 hours as I call 
>>> another vote.   So let me know what you think and I'll either 
>>> complete the release tomorrow generate some new artifacts and start 
>>> the vote again.
>>>
>>> Current results for 1.2.8:
>>>
>>> +1 Scott O'Bryan, Matthias Wessendorf
>>> +.5 Andrew Robinson
>>> -1 Paul Spencer because the Chart component doesn't work.
>>>
>>> Current results for 1.0.8
>>> +1 Scott O'Bryan, Matthias Wessendorf, Andrew Robinson
>>>
>>> I'll go ahead and keep votes open for one more day to allow people 
>>> to chime in or change their vote.
>>>
>>> Scott
>>>
>>> Paul Spencer wrote:
>>>> Venkata,
>>>> Thank you for your work on this issue.
>>>>
>>>> Paul Spencer
>>>>
>>>> venkata guddanti wrote:
>>>>> I believe yes.
>>>>>
>>>>>
>>>>> On Mon, May 19, 2008 at 1:54 PM, Paul Spencer 
>>>>> <paulspencer@mindspring.com>
>>>>> wrote:
>>>>>
>>>>>> Venkata,
>>>>>> Is this also an issue in 1.0.x?
>>>>>>
>>>>>> Paul Spencer
>>>>>>
>>>>>> venkata guddanti wrote:
>>>>>>
>>>>>>> I think I found out the reason why this is not working. The 
>>>>>>> ApacheChart.js
>>>>>>> is not registered in CoreCommonScriptsResourceLoader. I added

>>>>>>> the file to
>>>>>>> the debug and normal libraries list and it works. Do we need
a 
>>>>>>> JIRA ticket
>>>>>>> for this?
>>>>>>>
>>>>>>> Venkata
>>>>>>>
>>>>>>> On Mon, May 19, 2008 at 12:46 PM, venkata guddanti <
>>>>>>> ven.guddanti@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>> OK, I looked at the issue. It seems that the scriptlet output
is 
>>>>>>> broken
>>>>>>>> in
>>>>>>>> the latest trunk and 1.2 trunk. The chart  is rendered using
>>>>>>>> ApacheChart.js
>>>>>>>> on the client. The  Renderer creates a  new  Linbrary 
>>>>>>>> Scriptlet( new
>>>>>>>> LibraryScriptlet("ApacheChart", null)). It the uses
>>>>>>>> chartLib.outputScriptlet
>>>>>>>> to send the library to the browser. This seems to be broken.

>>>>>>>> Looking at
>>>>>>>> the
>>>>>>>> page source The library written is
>>>>>>>>
>>>>>>>> "/trinidad-demo-context-root/adf/jsLibs/DebugApacheChart1_2_8.js;jsessionid=0bef3a120e9dc7a98a8e960e4626cd56ee02bc717325f73e5bd3a0ae88bfd133".

>>>>>>>>
>>>>>>>> However this file seems to be invalid from the browser 
>>>>>>>> viewpoint. I only
>>>>>>>> see
>>>>>>>> "jsLibsDebugs/ApacheChart.js" in the output director.
>>>>>>>>
>>>>>>>> Does anybody know if the resource loader or something has

>>>>>>>> changed in the
>>>>>>>> latest release to cause this to happen?
>>>>>>>>
>>>>>>>> Venkata
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, May 19, 2008 at 12:09 PM, Scott O'Bryan 
>>>>>>>> <darkarena@gmail.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>> Cool, thanks Venkata, I'll wait to hear back as to whether
the 
>>>>>>>> issue is
>>>>>>>>> in
>>>>>>>>> the demo or the component before I close the vote.
>>>>>>>>>
>>>>>>>>> Scott
>>>>>>>>>
>>>>>>>>> venkata guddanti wrote:
>>>>>>>>>
>>>>>>>>> I will investigate the chart not working in 1.2.8 today.
>>>>>>>>>> Venkata
>>>>>>>>>>
>>>>>>>>>> On Thu, May 15, 2008 at 7:32 PM, Scott O'Bryan 
>>>>>>>>>> <darkarena@gmail.com
>>>>>>>>>> <mailto:
>>>>>>>>>> darkarena@gmail.com>> wrote:
>>>>>>>>>>
>>>>>>>>>>  Hi,
>>>>>>>>>>
>>>>>>>>>>  I was running the needed tasks to get the 1.2.8
release of the
>>>>>>>>>>  Apache MyFaces Trinidad out. The artifacts are deployed
to my
>>>>>>>>>>  private Apache account ([1]).
>>>>>>>>>>
>>>>>>>>>>  Please take a look at the "1.2.8" artifacts and
vote.  
>>>>>>>>>> Please note
>>>>>>>>>>  that this is my first time putting together a release
for 
>>>>>>>>>> Trinidad
>>>>>>>>>>  so if you could pay extra attention, I would be
much 
>>>>>>>>>> appreciative.
>>>>>>>>>>  ------------------------------------------------
>>>>>>>>>>  [ ] +1 for community members who have reviewed the
bits
>>>>>>>>>>  [ ] +0
>>>>>>>>>>  [ ] -1 for fatal flaws that should cause these bits
not to be
>>>>>>>>>>  released,
>>>>>>>>>>  and why..............
>>>>>>>>>>  ------------------------------------------------
>>>>>>>>>>
>>>>>>>>>>  Thanks,
>>>>>>>>>>  Scott
>>>>>>>>>>
>>>>>>>>>>  [1] 
>>>>>>>>>> http://people.apache.org/~sobryan/trinidad/1.2.8<http://people.apache.org/%7Esobryan/trinidad/1.2.8>

>>>>>>>>>>
>>>>>>>>>> <http://people.apache.org/%7Esobryan/trinidad/1.2.8>
>>>>>>>>>>  <http://people.apache.org/%7Esobryan/trinidad/1.2.8>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>
>>>>
>>>
>


Mime
View raw message