myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott O'Bryan (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TRINIDAD-930) tr:selectOneChoice resets value if not in form
Date Fri, 23 May 2008 17:57:55 GMT

    [ https://issues.apache.org/jira/browse/TRINIDAD-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599448#action_12599448
] 

Scott O'Bryan commented on TRINIDAD-930:
----------------------------------------

Point #5 is invalid because although it may work for you, that doesn't mean it will work for
everyone.  Andrew put in a -1 which means this, at the very least, warrants a discussion and
a vote.

Do you want to open a thread or should I?  A binding -1 vote is enough to make this patch
not go in so you'll probably need to make a better case.  Right now I'm -1 to THIS patch for
the reasons both I (and Andrew) have stated.  

> tr:selectOneChoice resets value if not in form
> ----------------------------------------------
>
>                 Key: TRINIDAD-930
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-930
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions: 1.2.6-core
>         Environment: JSF RI 1.2, Trinidad 1.2 trunk
>            Reporter: Martin Koci
>            Priority: Critical
>             Fix For: 1.2.5-core
>
>         Attachments: SimpleSelectOneRenderer.java.patch
>
>
> If tr:selectOneChoice is outside a h:form, it resets value used in value="#{}". Test
case:
> JSP snippet:
> <tr:selectOneChoice value="#{testBean.property}" unselectedLabel="(not selected)">
> 	<f:selectItem itemValue="value1" itemLabel="Item 1"/>
> </tr:selectOneChoice>
> <h:form> <!-- tr:selectOneChoice is not in the form -->
> 	<h:commandButton value="Ok" />
> </h:form>
> managed bean in session scope:
> public class TestBean {
>     
>     private String property = "value1";
>     
>     public String getProperty() {
>         return property;
>     }
>     public void setProperty(String property) {
>         this.property = property;
>     }
> }
>          
> Steps to reproduce problem:
> 1) Display jsp page - it shows "Item 1" in combobox
> 2) Click on "Ok" button 
> 3) Value in combobox will change to "(not selected)"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message