Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 7595 invoked from network); 17 Apr 2008 16:46:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Apr 2008 16:46:24 -0000 Received: (qmail 26585 invoked by uid 500); 17 Apr 2008 16:46:24 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 26548 invoked by uid 500); 17 Apr 2008 16:46:24 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 26535 invoked by uid 99); 17 Apr 2008 16:46:24 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Apr 2008 09:46:24 -0700 X-ASF-Spam-Status: No, hits=-2.8 required=10.0 tests=RCVD_IN_DNSWL_MED,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 141.146.126.228 is neither permitted nor denied by domain of darkarena@gmail.com) Received: from [141.146.126.228] (HELO agminet01.oracle.com) (141.146.126.228) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Apr 2008 16:45:30 +0000 Received: from agmgw2.us.oracle.com (agmgw2.us.oracle.com [152.68.180.213]) by agminet01.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id m3HGjlps003398; Thu, 17 Apr 2008 11:45:47 -0500 Received: from acsmt350.oracle.com (acsmt350.oracle.com [141.146.40.150]) by agmgw2.us.oracle.com (Switch-3.2.0/Switch-3.2.0) with ESMTP id m3HDsCV8010383; Thu, 17 Apr 2008 10:45:46 -0600 Received: from inet-141-146-46-1.oracle.com by acsmt350.oracle.com with ESMTP id 3653286131208450719; Thu, 17 Apr 2008 09:45:19 -0700 Received: from [10.139.120.34] (/10.139.120.34) by bhmail.oracle.com (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 17 Apr 2008 09:45:19 -0700 Message-ID: <48077ECD.1010103@gmail.com> Date: Thu, 17 Apr 2008 10:46:05 -0600 From: "Scott O'Bryan" User-Agent: Thunderbird 2.0.0.12 (X11/20080227) MIME-Version: 1.0 To: MyFaces Development Subject: Re: [Trinidad] added browser version support in skinning TRINIDAD-799 References: <5aca2d400804161524g3c9792f4g6b4da181266b590@mail.gmail.com> <4806883D.3010009@oracle.com> <5aca2d400804161734o1edc96daxf18c8ad968b1fe94@mail.gmail.com> <4806E85E.6060600@oracle.com> <5aca2d400804162332g5f2e7b5egb750ef8e117aa34d@mail.gmail.com> <4806F387.5090006@oracle.com> <37539e9a0804170847s5bd8133fu1f151b621c8672aa@mail.gmail.com> <71235db40804170921u4c6980d7mb4e3fbc7c8ee53d5@mail.gmail.com> In-Reply-To: <71235db40804170921u4c6980d7mb4e3fbc7c8ee53d5@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-Virus-Checked: Checked by ClamAV on apache.org MyFaces Core and the Portlet Bridge have an API policy in that the API is dictated by a Portlet Bridge spec. They don't have any guidelines in IMPL though. I think the majority of the projects rely on the committeers to review and test any additions. But like Matthias said, it's a good idea to bring it up in an email. Stuff tends to be better when the community is involved. Scott Matthias Wessendorf wrote: > Hi, > > On Thu, Apr 17, 2008 at 5:47 PM, Andy Schwartz > wrote: > >> On Thu, Apr 17, 2008 at 11:00 AM, Andrew Robinson >> wrote: >> > I would like to have: >> > >> > 1) Major and Major.Minor support >> > 2) A syntax that is already supported by CSS @ styles in at least one >> > browser or as close as we can come >> > 3) Range, greater than and less than if possible >> >> These all sound good to me. The underlying style handling layer (the >> old XSS stuff) was never designed to support #1 or #3, but think it >> would be worthwhile to see what we can do to address these. >> >> >> > >> > #2 I think is really important so that skinning feels familiar to CSS >> > developers. >> > >> > If the solution meets those needs, I will be very happy, but others >> > can decide on the exact syntax, I'm flexible >> >> I've got a process question here, which I am a bit hesitant to ask >> given our recent "discussions", but, well, what the heck... Shouldn't >> we be discussing/reviewing such requirements/API additions before the >> changes are committed to the trunks? Not that I am not grateful that >> > > at least (I personally think) having a "I am about to commit this" is not a > bad thing (tm) > > >> Cristi has invested the time on providing a solution (thanks for doing >> this Cristi!). I am just wondering whether in general it would be >> better to review/agree on new APIs before they get committed. >> >> Does Trinidad (or MyFaces) have any policy/guidelines on how new >> API/feature additions should be handled? Not picking on Cristi here - >> > > Nope. Not that I know. Some other Apache projects have; some not. > I think that for adding new APIs, we might want that we at least get > an alert before :-) > > >> I recently added some new skinning features myself and wasn't sure >> whether there were some specific steps that I needed to follow. >> > > haven't you ping the mailing list? If not, go ahead ! > > If it is just still in jira, well... it can be > there for a while. Bug trackers aren't that cool for discussions. Mailing > list are (I hate forums) > > -M > >> Andy >> >> > >