myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Wessendorf" <mat...@apache.org>
Subject Re: [Trinidad] private / protected final methods in renderers
Date Mon, 14 Apr 2008 14:22:13 GMT
On Mon, Apr 14, 2008 at 3:54 PM, Andrew Robinson
<andrew.rw.robinson@gmail.com> wrote:
> Yes, I understand, but when one mailing list member is holding up
>  progress by providing only negative, non-constructive feedback and
>  even admits that his own branch of the thread has ceased to be useful,

perhaps due to my lack of English these comments didn't sound that
"non-constructive" I understood them as a valid concerns, which IMO
legitimate to share them. BTW. here is an interesting FAQ ([1])

>  it is important to be able to let the other members of the community
>  have a say. This was the only way to stop unnecessary bickering from

I still don't like stopping contribtions that way...
 ...and we should keep the "discussion" open....

>  going on without end. As long as people are contributing helpful
>  feedback and are attempting to further the discussion and help make
>  proposals on how to fix problems, instead of just making negative
>  comments on how people work, then that feedback is welcome.


-Matthias
[1] http://wicket.sourceforge.net/faqs.html#why-final

>
>
>
>  On 4/14/08, Matthias Wessendorf <matzew@apache.org> wrote:
>  > On Fri, Apr 11, 2008 at 9:04 PM, Andrew Robinson
>  > <andrew.rw.robinson@gmail.com> wrote:
>  > >  If you are not a member of MyFaces, Committer or PMC member please
>  > >  refrain from further reply to this thread as your feedback has already
>  > >  been noted.
>  >
>  > as an asf member I really don't like statements like that...
>  > a strong community builds a strong product so, why not
>  > listening to contributors?
>  >
>  > -M
>  >
>  > >
>  > >  Thank you,
>  > >  Andrew
>  > >
>  > >
>  > >
>  > >
>  > >  On Wed, Apr 9, 2008 at 6:23 PM, Cristi Toth <cristi.toth@gmail.com>
>  > wrote:
>  > >  > Hi guys,
>  > >  >
>  > >  > A lot of Trinidad renderers have some "override useful" methods as
>  > private
>  > >  > or protected final.
>  > >  > This makes customizing renderers a nasty job.
>  > >  >
>  > >  > - first these methods obviously can't be overriden
>  > >  >  - then when trying to override some public/protected methods,
>  > >  >   it's hard because they use other private methods that you can't use
>  > in
>  > >  > your overriden method
>  > >  >
>  > >  > I assume this come from the fact that Trinidad wasn't open-source in
>  > its
>  > >  > origins... or?
>  > >  >  Do we still have reasons to keep it this way?
>  > >  >
>  > >  > IMO we could make those protected final "override useful" methods to
>  > >  > protected
>  > >  > and the private methods used in those methods, make them protected
>  > final.
>  > >  >
>  > >  > What's you opinion on this?
>  > >  >
>  > >  > Regards,
>  > >  > --
>  > >  > Cristi Toth
>  > >  >
>  > >  > -------------
>  > >  > Codebeat
>  > >  > www.codebeat.ro
>  > >
>  >
>  >
>  >
>  > --
>  > Matthias Wessendorf
>  >
>  > further stuff:
>  > blog: http://matthiaswessendorf.wordpress.com/
>  > sessions: http://www.slideshare.net/mwessendorf
>  > mail: matzew-at-apache-dot-org
>  >
>



-- 
Matthias Wessendorf

further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org

Mime
View raw message