Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Received-SPF: pass (athena.apache.org: domain of a.p.clement@gmail.com
 designates 64.233.178.247 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=NyNXD/3+J4FKGZszJ5x/JMgwUbm70/4wECyApIfZPxFZoYAFSEDlGBmAzyCKYG3xgrk+c6BDUYJtDk3M8y1ymH1UCdQqkCUrMEMQVu2Ky+MFagYNaoh+Wf4f/XGeq3pcGawECSbKvZk+I/nT5o2j9xqlZVBGK4HftdYfrPk43MM=
Message-ID: <44e376e00803280153td7ffa11x3547f3cc40adcea0@mail.gmail.com>
Date: Fri, 28 Mar 2008 09:53:36 +0100
From: "a clem" <a.p.clement@gmail.com>
To: "MyFaces Development" <dev@myfaces.apache.org>
Subject: Re: Ajax, pprPanelGroup and Portlets working together...
In-Reply-To: <6dda0b150803280141l273403c3gd050fd764091d3a3@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <44e376e00803240414o54a729c9jc8972bb6437113a4@mail.gmail.com>
	 <323d8a020803240621k2621b82bpa304476a1bb8193f@mail.gmail.com>
	 <6dda0b150803241423g2528a71fi8c4e084955100bc0@mail.gmail.com>
	 <44e376e00803261450hd0bddb0h14dc2995dbe52cd5@mail.gmail.com>
	 <f6c92360803271629v460030b9pa76233a7b7a18744@mail.gmail.com>
	 <47EC38BA.3060402@gmail.com>
	 <6dda0b150803280141l273403c3gd050fd764091d3a3@mail.gmail.com>

On Fri, Mar 28, 2008 at 9:41 AM, Ernst Fastl <ernst.fastl@gmail.com> wrote:
> +1 for ExternalContextUtils
>  Good idea Scott
>
>  In this case I wait for those utils before doing the changes in the
>  PPRPhaseListener
>
>  greez
>
>  E
>
>
>
>  On Fri, Mar 28, 2008 at 1:15 AM, Scott O'Bryan <darkarena@gmail.com> wrote:
>  > Take a look at Trinidad's ExternalContextUtils class.  It uses
>  >  reflection.  I'm also going to try to get something like this in the
>  >  myfaces commons, probably in the configurator package if I end up
>  >  submitting my current code.
>  >
>  >  If you don't have time to find the ExternalContextUtils on your own,
>  >  I'll try to post some source tomorrow.
>  >
>  >  Scott
>  >
>  >
>  >
>  >  Leonardo Uribe wrote:
>  >  > Hi
>  >  >
>  >  > I have seen lines like this on the attached files:
>  >  >
>  >  >         //Don't do the rendering twice
>  >  >         if (request instanceof PortletRequest &&
>  >  > ((PortletRequest)request).getAttribute(PPR_DONE_ATTR) != null) {
>  >  >             return;
>  >  >         }
>  >  >
>  >  > The problem here is that doing this makes that tomahawk requires
>  >  > portlet api to work, in non portlet environments.
>  >  >
>  >  > The same problem is present on MYFACES-434 patch.
>  >  >
>  >  > Can anyone suggest a way to avoid this dependency? or we should put
>  >  > portlet api as compile dependency for tomahawk?

I don't think this is a problem to have a dependancy on a standard API
since this an API (not an implementation) and a standard one.
This is known as the pattern 'dependency inversion'.
One alternative could be to develop a abstraction layer on top of the
standard servlet and portlet apis (to hide them).

regards

>  >  >
>  >  > regards
>  >  >
>  >  > Leonardo Uribe
>  >  >
>  >  >
>  >
>  >
>