myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Schwartz (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TRINIDAD-472) @agent support for icons
Date Wed, 05 Mar 2008 17:21:40 GMT

    [ https://issues.apache.org/jira/browse/TRINIDAD-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575427#action_12575427
] 

Andy Schwartz commented on TRINIDAD-472:
----------------------------------------

Note that the patch file adds several new files:

- trinidad-examples/trinidad-demo/src/main/webapp/skins/purple/images/collapsed.gif
- trinidad-examples/trinidad-demo/src/main/webapp/skins/purple/images/expanded.gif
- trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/skin/DocumentProviderSkin.java
- trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/skin/RequestSkinWrapper.java
- trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/xml/parse/IconNode.java

And deletes one file:

- trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/skin/parse/IconNode.java
(moved to style.xml.parse)

I see the contents of the new (ascii) files in my patch.  However, when I apply my patch locally,
the new files are created, but with no contents (zero size).  Similarly, the deleted file
is not deleted, but its contents are removed (again, zero size).  Also, the contents of the
two binary files (the gifs) don't seem to be included in the patch.

I'll provide an additional upload with the contents of the added files.

> @agent support for icons
> ------------------------
>
>                 Key: TRINIDAD-472
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-472
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Skinning
>    Affects Versions: 1.0.1-incubating-core-SNAPSHOT
>            Reporter: Jeanne Waldman
>             Fix For: 1.0.1-incubating-core-SNAPSHOT
>
>         Attachments: TRINIDAD-472.patch
>
>
> We have @agent support for skin selectors that are not icons, but not for icons.
> It would be useful to have different icons for ie than for gecko. For instance, we might
need different margins. And we could do this:
>   af|foo::bar-icon {
>     content: url(...);
>     margin-left: 2px
>   }
> @agent {
>   af|foo::bar-icon {
>     margin-left: 5px
>   }
> }
> What we have to do now is introduce a styleclass that goes around the icon in a span.
>   af|foo::bar-icon {
>     content: url(...);
>   }
>   af|foo::bar-icon-style {
>     margin-left: 2px
>   }
> @agent {
>   af|foo::bar-icon-style {
>     margin-left: 5px
>   }
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message