Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 45975 invoked from network); 22 Feb 2008 06:09:01 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Feb 2008 06:09:01 -0000 Received: (qmail 76148 invoked by uid 500); 22 Feb 2008 06:08:55 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 76112 invoked by uid 500); 22 Feb 2008 06:08:55 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 76101 invoked by uid 99); 22 Feb 2008 06:08:54 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Feb 2008 22:08:54 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Feb 2008 06:08:28 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 49AD8234C04D for ; Thu, 21 Feb 2008 22:08:19 -0800 (PST) Message-ID: <38437595.1203660499300.JavaMail.jira@brutus> Date: Thu, 21 Feb 2008 22:08:19 -0800 (PST) From: =?utf-8?Q?Matthias_We=C3=9Fendorf_=28JIRA=29?= To: dev@myfaces.apache.org Subject: [jira] Commented: (TRINIDAD-883) RenderKitDecorator.getRenderKit should not call getFactory on every call In-Reply-To: <18303510.1198868143116.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TRINIDAD-883?page=3Dcom.atlassi= an.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D12= 571286#action_12571286 ]=20 Matthias We=C3=9Fendorf commented on TRINIDAD-883: --------------------------------------------- why can't the RI remove locking? This is potential an issue for MyFaces as well.. > RenderKitDecorator.getRenderKit should not call getFactory on every call > ------------------------------------------------------------------------ > > Key: TRINIDAD-883 > URL: https://issues.apache.org/jira/browse/TRINIDAD-883 > Project: MyFaces Trinidad > Issue Type: Bug > Affects Versions: 1.2.4-core > Reporter: Stevan Malesevic > Assignee: Gabrielle Crawford > Fix For: 1.0.7-core, 1.2.7-core > > > org.apache.myfaces.trinidadinternal.renderkit.RenderKitDecorator.getRende= rKit() tries to get a instance of RenderKitFactory on every call. The prob= lem is that getFactory call results in locking. Since, according to documen= tation, RenderKitFactory::getFactory returns a per-web-application instance= of the appropriate implementation class for the specified JavaServer Faces= factory class, RenderKitDecorator.getRenderKit() should just used cached= RenderKitFactory=20 --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.