myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Wessendorf" <mat...@apache.org>
Subject Re: Can I add components to trinidad-sandbox
Date Wed, 13 Feb 2008 11:00:40 GMT
hi

On Feb 13, 2008 11:38 AM, Carsten Pieper <carsten.pieper@continentale.de> wrote:
>
> Argh, that's happening when users are posting on the developers' forum ;-}
> (I have been told, that it's OK to do so... If not, please let me know)

sure, nothing wrong with your post.

>
> > Would you be interested to make the sandbox 1.1 compatible ?
> > We could apply your patches to a special 1.1 branch, just as one option.
> Er, to be honest, right now I don't have the slightest idea how to do that.
> Neither in general nor for the tableFormLayout... So I can't make any real
> statement.
>
> However, we'll look at it to get a clue... But even if we get the impression
> that we could give it a try for the tableFormLayout  I surely can't promise,
> that we could / would take care for other components, that make it to the
> sandbox.
>
> Would that be OK for you or would you only start the 1.1 compatible branch
> with a dedicated sandbox keeper?

it is not up to me; the community has to make a decision.
Do we want a JSF 1.1 branch as well or not.

My vote would be -0

-Matthias

>
>
> Thanks, Carsten
>
>
> Matthias Wessendorf-4 wrote:
> >
> > Hi Carsten,
> >
> > On Feb 13, 2008 10:12 AM, Carsten Pieper <carsten.pieper@continentale.de>
> > wrote:
> >>
> >> Just to let you know:
> >>
> >> We love the idea of  the Trinidad sandbox - especially with the
> >> newly improved tableFormLayout in it!
> >>
> >> But... we're still on Trinidad 1.0.x, so that we'd prefer the sandbox to
> >> be compatible with both "branches".
> >
> > I think that "JSF 1.1 vs JSF 1.2" is a difficult question.
> >
> > I tend to prefer new features make it into a JSF 1.2 version of the
> > sandbox;
> >
> > Would you be interested to make the sandbox 1.1 compatible ?
> > We could apply your patches to a special 1.1 branch, just as one option.
> >
> > -M
> >>
> >> Thanks, Carsten
> >>
> >>
> >>
> >> Matthias Wessendorf-4 wrote:
> >> >
> >> > Hi,
> >> >
> >> > On Feb 12, 2008 8:45 PM, Leonardo Uribe <lu4242@gmail.com> wrote:
> >> >> Hi
> >> >>
> >> >> I have another question: trinidad sandbox should be for 1.2 ?
> >> >
> >> > +1 on that.
> >> >
> >> >>
> >> >> My component works if I do a light change on LabelAndMessageRenderer,
> >> can
> >> >> I
> >> >> change this class too?
> >> >>
> >> >> This is the patch file:
> >> >>
> >> >> Index:
> >> >>
> >> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> >> >>  ===================================================================
> >> >> ---
> >> >>
> >> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> >> >> (revision 614757)
> >> >> +++
> >> >>
> >> src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/LabelAndMessageRenderer.java
> >> >> (working copy)
> >> >>  @@ -279,6 +279,27 @@
> >> >>          }
> >> >>        }
> >> >>
> >> >> +      //This part is necessary to make work hspace on
> >> tr:tableFormLayout
> >> >> +      Map<String, Object> requestMap = context.getExternalContext()
> >> >> +          .getRequestMap();
> >> >>  +
> >> >> +      Integer hspaceObject = (Integer) requestMap.get(
> >> >> +              "org.apache.myfaces.trinidadinternal.TableFormHspace");
> >> >> +
> >> >> +      Boolean percentWidthObject = (Boolean) requestMap.get(
> >> >>  +
> >> >> "org.apache.myfaces.trinidadinternal.TableFormPercentWidth");
> >> >> +
> >> >> +      if (hspaceObject != null){
> >> >> +
> >> >> +          rw.startElement("td", null);
> >> >> +          if (percentWidthObject != null && percentWidthObject
==
> >> true){
> >> >>  +              rw.writeAttribute("width", hspaceObject +"%", null);
> >> >> +          }else{
> >> >> +              rw.writeAttribute("width", hspaceObject, null);
> >> >> +          }
> >> >> +          rw.endElement("td");
> >> >>  +      }
> >> >> +
> >> >>        _renderFieldCell(context, arc, component, bean, labelExists,
> >> >>                         needsPanelFormLayout, isInline);
> >> >>
> >> >> @@ -787,7 +808,8 @@
> >> >>    {
> >> >>      return "org.apache.myfaces.trinidad.Form".equals(rendererType)
||
> >> >>
> >> "org.apache.myfaces.trinidad.FormLayout".equals(rendererType)
> >> >> ||
> >> >> -        "org.apache.myfaces.trinidad.rich.Form".equals(rendererType);
> >> >> +        "org.apache.myfaces.trinidad.rich.Form".equals(rendererType)
> >> ||
> >> >>  +
> >> "org.apache.myfaces.trinidad.TableLayout".equals(rendererType);
> >> >>    }
> >> >>
> >> >>
> >> >>
> >> >> How does your comp differ from "panelFormLayout" ?
> >> >>
> >> >> An example is this
> >> >>
> >> >>                     <mycomp:tableFormLayout width="1000"
> >> >> columns="1*;2*;1*;2*">
> >> >>                          <tr:outputText value="Layout Example:
> >> Personal
> >> >> Information" >
> >> >>                             <f:attribute name="spanX" value="4"
/>
> >> >>                         </tr:outputText>
> >> >>
> >> >>                         <tr:selectOneChoice label="Salutation">
> >> >>                             <f:selectItem itemLabel="1 Option"
> >> >> itemValue="1"
> >> >> />
> >> >>                             <f:selectItem itemLabel="2 Option"
> >> >> itemValue="2"/>
> >> >>                          </tr:selectOneChoice>
> >> >>
> >> >>                         <tr:outputText>
> >> >>                             <f:attribute name="spanX" value="2"
/>
> >> >>                          </tr:outputText>
> >> >>
> >> >>                         <tr:inputText label="First Name"
> >> >> required="true"/>
> >> >>                          <tr:inputText label="Last Name"
> >> >> required="true"/>
> >> >>
> >> >>                         <tr:inputText label="c/o" required="true">
> >> >>                              <f:attribute name="spanXItem" value="3"
> >> />
> >> >>                         </tr:inputText>
> >> >>
> >> >>                         <tr:inputText label="Street" required="true"/>
> >> >>                          <tr:inputText label="No"  required="true"/>
> >> >>                         <tr:inputText label="ZIP"  required="true"/>
> >> >>                         <tr:inputText label="City"  required="true"/>
> >> >>                          <tr:inputText label="Note" rows="4"
> >> >> required="true">
> >> >>                             <f:attribute name="spanXItem" value="3"
/>
> >> >>                         </tr:inputText>
> >> >>                      </mycomp:tableFormLayout>
> >> >>
> >> >> It calculates widths, heights  for each component and make all layout
> >> >> tasks
> >> >> (colspan and others) more easy.
> >> >>
> >> >> You can see an screenshot on TRINIDAD-115
> >> >
> >> > not done yet, thanks for the pointer.
> >> >
> >> > -M
> >> >
> >> >>
> >> >>  regards
> >> >>
> >> >> Leonardo Uribe
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > Matthias Wessendorf
> >> >
> >> > further stuff:
> >> > blog: http://matthiaswessendorf.wordpress.com/
> >> > sessions: http://www.slideshare.net/mwessendorf
> >> > mail: matzew-at-apache-dot-org
> >> >
> >> >
> >>
> >> --
> >> View this message in context:
> >> http://www.nabble.com/Can-I-add-components-to-trinidad-sandbox-tp15440908p15451860.html
> >> Sent from the My Faces - Dev mailing list archive at Nabble.com.
> >>
> >>
> >
> >
> >
> > --
> > Matthias Wessendorf
> >
> > further stuff:
> > blog: http://matthiaswessendorf.wordpress.com/
> > sessions: http://www.slideshare.net/mwessendorf
> > mail: matzew-at-apache-dot-org
> >
> >
>
> --
> View this message in context: http://www.nabble.com/Can-I-add-components-to-trinidad-sandbox-tp15440908p15454092.html
>
> Sent from the My Faces - Dev mailing list archive at Nabble.com.
>
>



-- 
Matthias Wessendorf

further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org

Mime
View raw message