myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthias We├čendorf (JIRA) <...@myfaces.apache.org>
Subject [jira] Commented: (TRINIDAD-883) RenderKitDecorator.getRenderKit should not call getFactory on every call
Date Fri, 22 Feb 2008 06:08:19 GMT

    [ https://issues.apache.org/jira/browse/TRINIDAD-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571286#action_12571286
] 

Matthias We├čendorf commented on TRINIDAD-883:
---------------------------------------------

why can't the RI remove locking?
This is potential an issue for MyFaces as well..

> RenderKitDecorator.getRenderKit should not call getFactory on every call
> ------------------------------------------------------------------------
>
>                 Key: TRINIDAD-883
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-883
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>    Affects Versions: 1.2.4-core
>            Reporter: Stevan Malesevic
>            Assignee: Gabrielle Crawford
>             Fix For: 1.0.7-core, 1.2.7-core
>
>
> org.apache.myfaces.trinidadinternal.renderkit.RenderKitDecorator.getRenderKit() tries
to get a instance of  RenderKitFactory on every call. The problem is that getFactory call
results in locking. Since, according to documentation, RenderKitFactory::getFactory returns
a per-web-application instance of the appropriate implementation class for the specified JavaServer
Faces factory class,  RenderKitDecorator.getRenderKit()  should just used cached RenderKitFactory


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message