myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manfred Geiler" <manfred.gei...@gmail.com>
Subject Myfaces commons utils
Date Fri, 18 Jan 2008 16:04:07 GMT
Just had a look at the new commons-utils module and found the class "TagUtils".
Please forgive me for saying it directly: This piece of code is horrible!
It seems to be a mixture of various static methods without any direct
relation to "Tags". Looks like a huge graveyard for quick and dirty
static code pieces.
Having in mind a stable API (this is what we intended with these
commons jars - right?) I must say we SHOULD get rid of this code
and/or refactor it to several separate utils classes. Each one of them
having a clear and certain scope.

WDYT?

--Manfred

Mime
View raw message