myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Görß (JIRA) <...@myfaces.apache.org>
Subject [jira] Created: (TRINIDAD-856) Bug in panelTabbed with last selected element (SubTabBarRenderer)
Date Fri, 07 Dec 2007 10:22:43 GMT
Bug in panelTabbed  with last selected element     (SubTabBarRenderer)
----------------------------------------------------------------------

                 Key: TRINIDAD-856
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-856
             Project: MyFaces Trinidad
          Issue Type: Bug
          Components: Components
    Affects Versions: 1.2.3-core
            Reporter: Jan Görß


is the last element in panelTabbed select , separator-after-selected is missing

current   implementation
   start-cell
   separator
   element
   separator-before-selected
   element
   end-cell


in my opinion is this correct
  start-cell
  separator
  element
  separator-before-selected
  element
  separator-after-selected
  end-cell

I think, this is a bug.



the solution for the last select element is in File org.apache.myfaces.trinidadinternal.ui.laf.base.desktop.SubTabBarRenderer


@Override
  protected void postrender(
    UIXRenderingContext context,
    UINode           node
    ) throws IOException
  {

    ResponseWriter writer = context.getResponseWriter();
   
     Boolean afterSelected = (Boolean)context.getLocalProperty(
                                                              0, _AFTER_SELECTED_KEY, Boolean.FALSE);

   if(afterSelected)
  {
    writer.startElement(TABLE_DATA_ELEMENT, null);
    renderStyleClassAttribute(context, _SEPARATOR_AFTER_SELECTED_STYLE);
    writer.endElement(TABLE_DATA_ELEMENT);
 } 



 writer.startElement(TABLE_DATA_ELEMENT, null);
    // use a style class instead attribute for width=100%. 
    // This way the user can change this if he wants it centered.
    renderStyleClassAttribute(context, _CELL_END_STYLE);
    //IE seems to need something in the cell in order for styles to take effect. 
    renderHorizontalSpacer(context, "0");    
    writer.endElement(TABLE_DATA_ELEMENT);


    // Re-enable default link style classes
    LinkUtils.endDefaultStyleClassDisabled(context);
    writer.endElement(TABLE_ROW_ELEMENT);
    super.postrender(context, node);
    renderRelatedLinksBlockEnd(context);

  }





-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message