Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 37507 invoked from network); 2 Nov 2007 16:06:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Nov 2007 16:06:14 -0000 Received: (qmail 55283 invoked by uid 500); 2 Nov 2007 16:06:01 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 55265 invoked by uid 500); 2 Nov 2007 16:06:01 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 55254 invoked by uid 99); 2 Nov 2007 16:06:01 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Nov 2007 09:06:01 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Nov 2007 16:06:11 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 43E08714236 for ; Fri, 2 Nov 2007 09:05:51 -0700 (PDT) Message-ID: <7855929.1194019551274.JavaMail.jira@brutus> Date: Fri, 2 Nov 2007 09:05:51 -0700 (PDT) From: "Scott O'Bryan (JIRA)" To: dev@myfaces.apache.org Subject: [jira] Commented: (TRINIDAD-792) Making Reorder,Remove ChildComponentChange generic to all the attributes In-Reply-To: <5053624.1193930750620.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TRINIDAD-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539625 ] Scott O'Bryan commented on TRINIDAD-792: ---------------------------------------- Hey Shafi, 1.2.3-core has been release meaning we can't really change it. Is this a change that is specific to the 1.2 branch or is this something that we should commit to trunk? > Making Reorder,Remove ChildComponentChange generic to all the attributes > ------------------------------------------------------------------------ > > Key: TRINIDAD-792 > URL: https://issues.apache.org/jira/browse/TRINIDAD-792 > Project: MyFaces Trinidad > Issue Type: Improvement > Components: Components > Affects Versions: 1.2.3-core > Reporter: shafi khan > Assignee: Scott O'Bryan > Attachments: trunk.patch > > > This is to avoid the requirement that " id attribute should always be specified for the children' in case of RemoveChildComponentChange, ReorderChildrenComponentChange. > This makes the user to always specify 'id' attribute explicitly on the children. This leads to an increase of html output. Instead they can have custom attribute on the component. The users will have to pass custom attribute's value and custom attribute's name to the RemoveChildComponentChange's constructor. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.