myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Cooper" <matt.fa...@gmail.com>
Subject Re: [Trinidad] Trunk broken
Date Fri, 16 Nov 2007 18:25:22 GMT
FYI - I went ahead and commited the golden file changes r595766.

Perhaps I lost the email but I am a little concerned that I never saw
a continuum build failure for this so there may be yet a bigger issue
here too with the build automation.

Regards,
Matt

On Nov 15, 2007 6:21 AM, Matthias Wessendorf <matzew@apache.org> wrote:
> There is also a wiki page about it (see [1])
>
> -M
>
> [1] http://wiki.apache.org/myfaces/Trinidad_RenderKit_test_framework
>
>
> On Nov 15, 2007 2:44 AM, Catalin Kormos <catalin.kormos@gmail.com> wrote:
> > Hi Jeanne,
> >
> > That's great, many thanks for providing this information, as i wasn't very
> > sure how to tackle it.
> >
> > regards,
> > Catalin
> >
> >
> >
> > On Nov 15, 2007 3:33 AM, Jeanne Waldman < jeanne.waldman@oracle.com> wrote:
> > > No objections.
> > >
> > > The normal practice is when I see test failures, I go to the
> > > test-failures directory. In your case, you see
> > > treeTable-minimal-golden.xml, treeTable-minimalIE-golden.xml, etc.
> > >
> > > Then what I do is diff the src with the test-failures. So you would
> > > look at the diff between the src treeTable-minimal-golden.xml and the
> > > test-failure file of the same name. If the diff is what you expect, then
> > > you copy your test-failure file into the src file.
> > >
> > > Then you rebuild. If it is successful, you check in, so you'll check in
> > > the treeTable*golden.xml files and the build will run for everyone.
> > >
> > > The golden file tests are a great way to catch accidental changes to
> > > renderers.
> > >
> > > Thanks,
> > > Jeanne
> > >
> > >
> > > Catalin Kormos wrote:
> > > > Hi,
> > > >
> > > > Yes you're right, sorry about that; before, text icons were supported,
> > > > and the patch introduced image icons, and the tests weren't patched yet.
> > > > If nobody has any objections, we'll update the tests also, asap, to test
> > > > for img instead of span in the ouput.
> > > >
> > > > regards,
> > > > Catalin
> > > >
> > > > On Nov 14, 2007 11:33 PM, Andrew Robinson <andrew.rw.robinson@gmail.com
> > >
> > >
> > >
> > > > <mailto:andrew.rw.robinson@gmail.com>> wrote:
> > > >
> > > >     The current trunk (1.0.5) is broken in SVN with the golden files
> > test
> > > >     failing for the treeTable. Looks like img tags are now being used
> > > >     instead of span elements.
> > > >
> > > >     I think it was revision 595029 that broke it:
> > > >
> > > >     r595029 | ckormos | 2007-11-14 13:14:19 -0700 (Wed, 14 Nov 2007) |
1
> > > >     line
> > > >     Changed paths:
> > > >       M
> > /myfaces/trinidad/trunk/trinidad/src/site/xdoc/skin-selectors.xml
> > > >       M
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/java/org/apache/myfaces/trinidaddemo/DemoTreeData.java
> > > >
> > > >       M
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/java/org/apache/myfaces/trinidaddemo/InfiniteTree.java
> > > >       M
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/java/org/apache/myfaces/trinidaddemo/TreeNodeImpl.java
> > > >
> > > >       M
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/webapp/demos/panelPageSkinDemo.jspx
> > > >       M
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/webapp/skins/beach/beach.css
> > > >
> > > >       A
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/webapp/skins/beach/images/document.png
> > > >       A
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/webapp/skins/beach/images/yellow-
> > > >     folder-closed.png
> > > >       A
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/webapp/skins/beach/images/yellow-folder-open.png
> > > >       M
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-examples/trinidad-demo/src/main/webapp/skins/purple/purpleSkin.css
> > > >
> > > >       M
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/desktop/TreeTableRenderer.java
> > > >       M
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/skin/BaseDesktopSkin.java
> > > >
> > > >       M
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SkinProperties.java
> > > >       M
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SkinSelectors.java
> > > >
> > > >       M
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/TreeRenderer.java
> > > >       M
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/table/TreeNodeColumnRenderer.java
> > > >
> > > >       A
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/images/nav-minus.gif
> > > >       A
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/images/nav-
> > plus.gif
> > > >       A
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/images/tree-
> > > >     line-last.gif
> > > >       A
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/images/tree-
> > line-middle.gif
> > > >       A
> > > >
> > /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/resources/META-INF/adf/images/tree-
> > > >     line-trunk.gif
> > > >
> > > >     fix for TRINIDAD-769 Tree / TreeTable skinning improvements (thanks
> > to
> > > >     Cristi Toth for provinding the patch).
> > > >
> > ------------------------------------------------------------------------
> > > >
> > > >
> > >
> >
> >
>
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> mail: matzew-at-apache-dot-org
>

Mime
View raw message