myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leonardo Uribe (JIRA)" <>
Subject [jira] Commented: (TRINIDAD-115) Layout Component for Trinidad - TableFormLayout
Date Mon, 26 Nov 2007 00:15:43 GMT


Leonardo Uribe commented on TRINIDAD-115:

Now the component allows define width as percent:

<mycomp:tableFormLayout width="100%" cellspacing="5"

The main problem to add this was a problem with IE (the end of input components was cut off)
with is solved creating an skin addition (this api is really cool!) that adds 


on IE. This solves partially the problem, but still the component is draw 4 or 5 pixels outside
the cell. If you put something like this on the page:

<html xmlns="" >

IE works well

> Layout Component for Trinidad - TableFormLayout
> -----------------------------------------------
>                 Key: TRINIDAD-115
>                 URL:
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Components
>            Reporter: Leonardo Uribe
>            Priority: Minor
>         Attachments: patchTableFormLayout.patch, screenshot-1.jpg,,,,
> Hi
> I want to put on consideration or discusion of the community this component that I have
made to work with trinidad.
> The component is similar to <tc:gridLayout> component in tobago, but are build
following the rules
> of trinidad to manage this components.
> The component was build based on panelFormLayout way to do this
> I have attached to this issue  a project called TableFormLayout. But for run, It's necessary
to modify a 
> method (really add a single line) of the class LabelAndMessageRenderer (I also provide
a patch) on 
> trinidad-impl-1.0.2-SNAPSHOT
>   private boolean _isFormRendererType(String rendererType)
>   {
>     return "org.apache.myfaces.trinidad.Form".equals(rendererType) ||
>         "org.apache.myfaces.trinidad.FormLayout".equals(rendererType) ||
>         "".equals(rendererType) ||
>         "org.apache.myfaces.trinidad.TableLayout".equals(rendererType);
>   }
> I don't like this patch, but LabelAndMessageRenderer has some coupling with PanelFormLayoutRenderer.
The central
> problem is that this renderer has to look things about its environment, but a component
should not assume things
> of his environment. I want to discuss this in another discusion in myfaces-dev mailing
> The component is not finished yet, but i have made 3 examples that I want to show to
the community in order to 
> modify it.
> Suggestions are welcome.
> regards
> Leonardo Uribe

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message