myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Lessard" <simon.lessar...@gmail.com>
Subject Re: [jira] Resolved: (PORTLETBRIDGE-6) JDK 1.5 Functionality
Date Wed, 21 Nov 2007 13:37:53 GMT
Ok, thanks. I saw the Vector as well but didn't want to evaluate if
synchronization was really required or not. It seems it wasn't. I'm going to
check the new version to see if you included some of the other possible
optimizations I saw but didn't work on. The only one I could not skip though
was the use of an unsorted array for the exclusion list. I replaced that
with a TreeSet to get O(ln n) access time rather than O(n).

~ Simon

On Nov 20, 2007 7:22 PM, Scott O'Bryan (JIRA) <dev@myfaces.apache.org>
wrote:

>
>     [
> https://issues.apache.org/jira/browse/PORTLETBRIDGE-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Scott O'Bryan resolved PORTLETBRIDGE-6.
> ---------------------------------------
>
>    Resolution: Fixed
>
> Hey Simon, I fixed the few issues you had and added a couple more small
> optimization (including replacing uses of Vector with a List).  That patch
> was very complete and very well done.  Thanks...
>
> > JDK 1.5 Functionality
> > ---------------------
> >
> >                 Key: PORTLETBRIDGE-6
> >                 URL:
> https://issues.apache.org/jira/browse/PORTLETBRIDGE-6
> >             Project: MyFaces Portlet Bridge
> >          Issue Type: Improvement
> >          Components: General
> >    Affects Versions: 1.0.0-SNAPSHOT
> >            Reporter: Scott O'Bryan
> >            Assignee: Simon Lessard
> >         Attachments: PORTLETBRIDGE-6.patch
> >
> >
> > The bridge was originally coded to the JDK1.4 standard.  Since JSF1.2requires JDK5,
we should follow the JDK5 standards for speed and
> reliability.  Most notibly:
> > * Specify generics wherever possible - especially in the ExternalContext
> implementations which use this by default
> > * Remove the SimpleStringBuilder class in impl and replace it's usage
> with StringBuilder
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Mime
View raw message