Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Received-SPF: pass (nike.apache.org: domain of awiner@gmail.com designates
 209.85.146.182 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=K3iUuEL8RsToZX1nWyX0vaRMHvO8uk482s1GmNjO9PnKGb3KPY2SdXlUWoUb5i67YD9fQMTQVxMY/1hY10qmwfWvDt5s4HH5qSILhaQvv8zHmEdFvFeeqcqexYcQhEpbLyPKuRl9zZNz7sAU9gONxp/KfupWdsN+wMJgIa0OME8=
Message-ID: <6dac79b90709251136n40b13c3vb2e27090b9789fc9@mail.gmail.com>
Date: Tue, 25 Sep 2007 11:36:19 -0700
From: "Adam Winer" <awiner@gmail.com>
To: "MyFaces Development" <dev@myfaces.apache.org>
Subject: Re: [jira] Resolved: (TRINIDAD-731) xOffset/yOffset don't get
 correctly processed by plugins,
 switch to horzOffset/vertOffset for simplicity and clarity.
In-Reply-To: <5bbf92e70709250721t2710b84ag83ad696c9e106f28@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <30667062.1190384990607.JavaMail.jira@brutus>
	 <28428568.1190406050571.JavaMail.jira@brutus>
	 <bc36a6210709211323s824a690j1e246bd4522d15b7@mail.gmail.com>
	 <5bbf92e70709211328v364d695n8726fb1d07813887@mail.gmail.com>
	 <6dac79b90709211956w3743bb22x8cda773724dee118@mail.gmail.com>
	 <5bbf92e70709240625m2cdcfd85w3b5ccb6bc3805726@mail.gmail.com>
	 <6dac79b90709241352l4c422096x15be0af81996b168@mail.gmail.com>
	 <5bbf92e70709250721t2710b84ag83ad696c9e106f28@mail.gmail.com>

It's probably the case that the component and JSP tag methods
need to be setxOffset instead of setXOffset() - or you need to
supply a BeanInfo.

But the best and simplest option, I think, is just to rename the
properties to xoffset and yoffset, no caps - like halign and valign.

-- Adam


On 9/25/07, Danny Robinson <dannyjrobinson@gmail.com> wrote:
> Both.
>
> If you grab the trunk and tweak the CorePanelPopup.xml attributes back to
> using xOffset/yOffset, then also tweak findTypeConstants() in the renderer,
> then...
>
> In JSP, you get
>
> /components/panelPopup.jspx(39,102) Unable to find setter
> method for attribute: yOffset
>
> In Facelets, you get
> java.lang.ClassCastException: java.lang.String
>  at
> org.apache.myfaces.trinidad.render.CoreRenderer.toInt(CoreRenderer.java:127)
>  at
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPopupRenderer.getHorzOffset
> (PanelPopupRenderer.java:103)
>
> as the attribute gets read, but is held internally as a String
>
> I took a look around the generated artifacts, but nothing jumps out as
> wrong.
>
> D.
>
>
>  On 9/24/07, Adam Winer <awiner@gmail.com> wrote:
> > Remind me what the issue is?  Is it JSP tags,
> > Facelets, both, something else?
> >
> > -- Adam
> >
> >
> > On 9/24/07, Danny Robinson <dannyjrobinson@gmail.com> wrote:
> > > I know.  When I made the name changes, I knew the plugins should really
> get
> > > fixed ;-).  Any hints on where to look in the plugins would really help
> > > (unknown territory), then I can get the attribute names reverted.
> > >
> > > D.
> > >
> > > On 9/21/07, Adam Winer <awiner@gmail.com> wrote:
> > > > Yech, why don't we just fix the plugins???
> > > >
> > > > -- Adam
> > > >
> > > >
> > > > On 9/21/07, Danny Robinson <dannyjrobinson@gmail.com> wrote:
> > > > > Hard to say that they are breaking, because I'm not certain they
> ever
> > > worked
> > > > > ;-)
> > > > >
> > > > > I'll update the release notes to cover this though.
> > > > >
> > > > > D.
> > > > >
> > > > >
> > > > > On 9/21/07, Andrew Robinson < andrew.rw.robinson@gmail.com > wrote:
> > > > > > Is this a compatibility breaking change (meaning that the old
> > > > > > attributes were removed)?
> > > > > >
> > > > > > If so, were are these items documented so that users know what
> > > happened?
> > > > > >
> > > > > > -Andrew
> > > > > >
> > > > > > On 9/21/07, Danny Robinson (JIRA) < dev@myfaces.apache.org> wrote:
> > > > > > >
> > > > > > >      [
> > > > >
> > >
> https://issues.apache.org/jira/browse/TRINIDAD-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> > > > > ]
> > > > > > >
> > > > > > > Danny Robinson resolved TRINIDAD-731.
> > > > > > > -------------------------------------
> > > > > > >
> > > > > > >        Resolution: Fixed
> > > > > > >     Fix Version/s: 1.0.3-core
> > > > > > >
> > > > > > > Switched attribute names to horzOffset and vertOffset.
> > > > > > >
> > > > > > > > xOffset/yOffset don't get correctly processed by plugins,
> switch
> > > to
> > > > > horzOffset/vertOffset for simplicity and clarity.
> > > > > > > >
> > > > >
> > >
> ---------------------------------------------------------------------------------------------------------------------
> > > > > > > >
> > > > > > > >                 Key: TRINIDAD-731
> > > > > > > >                 URL:
> > > > > https://issues.apache.org/jira/browse/TRINIDAD-731
> > > > > > > >             Project: MyFaces Trinidad
> > > > > > > >          Issue Type: Improvement
> > > > > > > >          Components: Components
> > > > > > > >    Affects Versions: 1.0.3-core
> > > > > > > >            Reporter: Danny Robinson
> > > > > > > >            Assignee: Danny Robinson
> > > > > > > >            Priority: Minor
> > > > > > > >             Fix For: 1.0.3-core
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > This message is automatically generated by JIRA.
> > > > > > > -
> > > > > > > You can reply to this email to add a comment to the issue
> online.
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Chordiant Software Inc.
> > > > > www.chordiant.com
> > > >
> > >
> > >
> > >
> > > --
> > > Chordiant Software Inc.
> > > www.chordiant.com
> >
>
>
>
> --
>
> Chordiant Software Inc.
> www.chordiant.com