Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 7628 invoked from network); 22 Sep 2007 01:40:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Sep 2007 01:40:08 -0000 Received: (qmail 95556 invoked by uid 500); 22 Sep 2007 01:39:58 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 95517 invoked by uid 500); 22 Sep 2007 01:39:58 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 95506 invoked by uid 99); 22 Sep 2007 01:39:57 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Sep 2007 18:39:57 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of awiner@gmail.com designates 209.85.198.191 as permitted sender) Received: from [209.85.198.191] (HELO rv-out-0910.google.com) (209.85.198.191) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Sep 2007 01:39:58 +0000 Received: by rv-out-0910.google.com with SMTP id c27so863017rvf for ; Fri, 21 Sep 2007 18:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=nHD/O0Hb/DKQ0HFcnXjIOzZ+ZTpd8yqWtBZcMzTXfTQ=; b=cp0huWJOmBVGNf4fi+1TVsh2D2iuFvDgZhPXh7XpXSrU6FSKglOD62JGkksY0FXrznfromxefC8zrhoWUWi6291YcfyizfxlvcyiUiTDqQyH2FKCngC9/CSj/xy6Iio8Qebcp4gVaM6ziiEeESsWa8babaSMF+OtXy8ddv78EUQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=K9AgN0MhBF8sZzuhYwjKvut0mof2aC4Dx3kfcQH+qpWyEi7Y+xZR9ewHbGlJ7WI4fkBWH4+R+2WCa7Bj5F2MGHd7vQmMv+tt8a3dfXUi/HDG6sOaWRkKk9fne1+YCDgblFrOne9TZ+Vkzg3fGaqlbRUyRVBqLIpPaJ7DjLkWjrs= Received: by 10.114.58.1 with SMTP id g1mr4220641waa.1190425177257; Fri, 21 Sep 2007 18:39:37 -0700 (PDT) Received: by 10.141.172.7 with HTTP; Fri, 21 Sep 2007 18:39:36 -0700 (PDT) Message-ID: <6dac79b90709211839q58003ef7ge7b87297b2259488@mail.gmail.com> Date: Fri, 21 Sep 2007 18:39:36 -0700 From: "Adam Winer" To: "MyFaces Development" Subject: Re: [TRINIDAD] New element in trinidad-skins.xml /SkinImpl/SkinAddition In-Reply-To: <092120071945.10107.46F41F4200052FE80000277B22007507440A9D9B0E03020E9009@comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <092120071945.10107.46F41F4200052FE80000277B22007507440A9D9B0E03020E9009@comcast.net> X-Virus-Checked: Checked by ClamAV on apache.org -1 to trying to turn everything into ResourceBundle. Just use EL - ELResolver in 1.2, PropertyResolver in 1.1. As of 1.2, that gives you ResourceBundle and Map support. In 1.1, only Map (and bean, of course), but then again in 1.1 how do you get unwrapped ResourceBundle instances into EL anyway? @Gary: the Shale LoadBundle class seems quite unnecessary in 1.2, right? -- Adam On 9/21/07, Gary VanMatre wrote: > > >From: "Simon Lessard" > > > > > > > >If we accept only a map, it's quite exclusive, unless we add yet another > tag, but I would be -1 on >that. However, as Adam suggested, we could call > it "translation-source" and support both Map and >ResourceBundle instances. > We have to a very thin adapter Map --> ResourceBundle if a Map >instance is > passed and the remaining code will continue to work as it's now, with a > ResourceBundle. > > > FWIW, Shale has a utility class that sounds very similar to what you have > described [1]. > > > [1] > http://svn.apache.org/viewvc/shale/framework/trunk/shale-core/src/main/java/org/apache/shale/util/LoadBundle.java?view=markup > > > > > > >~ Simon > > Gary >