myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Winer" <awi...@gmail.com>
Subject Re: [Trinidad] Branch for 1.0.3 core ?
Date Tue, 25 Sep 2007 21:09:17 GMT
On 9/25/07, Danny Robinson <dannyjrobinson@gmail.com> wrote:
>
> > This looks like it fails if validation is set to alert mode;  _autoSubmit
> > always calls _validateInput, which calls _validateInline.
>
> Thanks, fixed.
>
> > Also, if immediate is true, the _autoSubmit param validateForm is true?
> > That seems weird...
>
> BodyRenderer actually uses the snippet below, so whole-form validation
> shouldn't happen if immediate is true.
> builder.append(immediate ? "0" : "1");
>
> > I think I've seen this code:
> > +  if (_agent.isIE)
> > +  {
> > +    // in many forms there is a hidden field named "event"
> > +    // Sometimes IE gets confused and sends us that instead of
> > +    // the true event, so...
> > +    if (event["type"] == "hidden")
> > +      event = window.event;
> > +  }
> > +
> >
> > ... elsewhere.  Never a good thing to cut-and-paste in JS.
>
> Do you mean abstract both copies into a common method, or are you
> questioning the actual code.

Both should go into a common method, I think.  Maybe
we could start to use some polymorphism on the agent object,
so you could just call event = _agent.getEvent(event)?

-- Adam


>  If that's the case, I spent a few hours one
> evening trying to understand why I wasn't getting the 'real' event object in
> IE.

>
> > -- Adam
> >
> >
> > On 9/25/07, Danny Robinson < dannyjrobinson@gmail.com> wrote:
> > > I'd like some quick eyes on the patch I've attached to TRINIDAD-37 which
> I'd
> > > like to commit if there are no issues.
> > >
> > >
> > >
> > >
> > > On 9/25/07, Adam Winer < awiner@gmail.com> wrote:
> > > > I think Danny still has some things?
> > > >
> > > > -- Adam
> > > >
> > > >
> > > > On 9/25/07, Matthias Wessendorf < matzew@apache.org> wrote:
> > > > > anyone else that has some changes to commit ?
> > > > >
> > > > > Otherwise I start the branch tomorrow morning (German time)
> > > > >
> > > > > -Matthias
> > > > >
> > > > > On 9/25/07, Adam Winer <awiner@gmail.com > wrote:
> > > > > > OK, I've fixed 735, and checked in the patches
> > > > > > for 674 and 676.
> > > > > >
> > > > > > -- Adam
> > > > > >
> > > > > >
> > > > > > On 9/24/07, Adam Winer < awiner@gmail.com> wrote:
> > > > > > > We've also got patches available for TRINIDAD-718 and
> > > > > > > TRINIDAD-665 (actually looks like TRINIDAD-718 has
> > > > > > > already been checked in, but the JIRA wasn't closed).
> > > > > > >
> > > > > > > TRINIDAD-735 would be nice, but isn't critical.
> > > > > > >
> > > > > > > I'll check in the fixes for TRINIDAD-674 and TRINIDAD-676
> > > > > > > ASAP - straightforward fixes from Tomas Havelka, a shame
> > > > > > > to let them go unused.
> > > > > > >
> > > > > > > Anyone else have something they really want fixed for 1.0.3?
> > > > > > >
> > > > > > > Going forward, I don't think we need to have a strict
> > > > > > > "release the plugins, then release core" rule - I think
we
> > > > > > > can mostly get away with just releasing core, when it's
> > > > > > > ready.  Which is good. :)
> > > > > > >
> > > > > > > -- Adam
> > > > > > >
> > > > > > >
> > > > > > > On 9/24/07, Simon Lessard < simon.lessard.3@gmail.com
> wrote:
> > > > > > > > Ok, commit is done on my side.
> > > > > > > >
> > > > > > > >
> > > > > > > > On 9/24/07, Matthias Wessendorf < matzew@apache.org>
wrote:
> > > > > > > > > Sounds good to me,
> > > > > > > > > this email was just a heads-up ;-)
> > > > > > > > >
> > > > > > > > > On 9/24/07, Simon Lessard < simon.lessard.3@gmail.com>
> wrote:
> > > > > > > > > > I need to commit the patch for statusIndicator.
I'll do
> that
> > > later
> > > > > > > > today, we
> > > > > > > > > > should not release until it's done.
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On 9/24/07, Matthias Wessendorf < matzew@apache.org
>
> wrote:
> > > > > > > > > > > one more.
> > > > > > > > > > >
> > > > > > > > > > > from September 30th => October 15th
(incl.) I am away
> from
> > > any
> > > > > > > > computer !
> > > > > > > > > > :-)
> > > > > > > > > > > (vacation)
> > > > > > > > > > >
> > > > > > > > > > > So, the goal of this email was to prepare
as much as
> > > possible to get
> > > > > > > > > > > the release out
> > > > > > > > > > > by end of this week ;-)
> > > > > > > > > > >
> > > > > > > > > > > Otherwise someone else needs to do
the release
> procedure.
> > > > > > > > > > >
> > > > > > > > > > > -Matthias
> > > > > > > > > > >
> > > > > > > > > > > On 9/24/07, Matthias Wessendorf <
matzew@apache.org>
> wrote:
> > > > > > > > > > > > On 9/24/07, Danny Robinson <
dannyjrobinson@gmail.com
> >
> > > wrote:
> > > > > > > > > > > > > Did I miss the conversation
leading up to this, or
> is
> > > this it?
> > > > > > > > > > > >
> > > > > > > > > > > > there was no thread regarding
this.
> > > > > > > > > > > >
> > > > > > > > > > > > Usually after the release of the
plugins, we start
> with
> > > the release
> > > > > > > > > > > > procedure of the core.
> > > > > > > > > > > > Since the vote on plugins is already
ongoing, I was
> asking
> > > if we
> > > > > > > > > > > > should wait more days or not.
> > > > > > > > > > > > Looks like you've something for
the 1.0.3, so we wait.
> > > That's fine.
> > > > > > > > > > > >
> > > > > > > > > > > > -M
> > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > To Do
> > > > > > > > > > > > > * resolve the current xOffset/yOffset
conversation
> and
> > > fix the
> > > > > > > > plugins
> > > > > > > > > > > > > * Update AutoSubmitUtils
to output '
> > > TrPage._autoSubmit()' as the
> > > > > > > > > > onchange
> > > > > > > > > > > > > handler
> > > > > > > > > > > > >
> > > > > > > > > > > > > Danny
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > On 9/24/07, Matthias Wessendorf
< matzew@apache.org
> >
> > > wrote:
> > > > > > > > > > > > > > Hi,
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > I'd like to branch today
for the upcoming
> 1.0.3-core
> > > release of
> > > > > > > > > > > > > > Trinidad. Does one need
to commit something before
> ?
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > thx,
> > > > > > > > > > > > > > Matthias
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > --
> > > > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > > > >
> > > > > > > > > > > > > > further stuff:
> > > > > > > > > > > > > > blog:
> > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > >
> > > > > > > > > > > > > --
> > > > > > > > > > > > > Chordiant Software Inc.
> > > > > > > > > > > > >   www.chordiant.com
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > > > --
> > > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > > >
> > > > > > > > > > > > further stuff:
> > > > > > > > > > > > blog:
> > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > --
> > > > > > > > > > > Matthias Wessendorf
> > > > > > > > > > >
> > > > > > > > > > > further stuff:
> > > > > > > > > > > blog:
> > > http://matthiaswessendorf.wordpress.com/
> > > > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Matthias Wessendorf
> > > > > > > > >
> > > > > > > > > further stuff:
> > > > > > > > > blog:
> http://matthiaswessendorf.wordpress.com/
> > > > > > > > > mail: matzew-at-apache-dot-org
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Matthias Wessendorf
> > > > >
> > > > > further stuff:
> > > > > blog: http://matthiaswessendorf.wordpress.com/
> > > > > mail: matzew-at-apache-dot-org
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > >
> > > Chordiant Software Inc.
> > > www.chordiant.com
> >
>
>
>
> --
>
> Chordiant Software Inc.
> www.chordiant.com

Mime
View raw message