myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Lessard (JIRA)" <...@myfaces.apache.org>
Subject [jira] Resolved: (TRINIDAD-130) Add non-final getSelectItems method to SimpleSelectOneRenderer
Date Mon, 10 Sep 2007 20:19:29 GMT

     [ https://issues.apache.org/jira/browse/TRINIDAD-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Simon Lessard resolved TRINIDAD-130.
------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.0.2-core)
                   1.0.3-core

Applied patch part II to the trunk.

> Add non-final getSelectItems method to SimpleSelectOneRenderer
> --------------------------------------------------------------
>
>                 Key: TRINIDAD-130
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-130
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Components
>    Affects Versions: 1.0.1-core
>            Reporter: Simon Lessard
>            Assignee: Simon Lessard
>            Priority: Minor
>             Fix For: 1.0.3-core
>
>         Attachments: TRINIDAD-130-part2.patch, TRINIDAD-130.patch
>
>
> Currently, SimpleSelectOneRenderer get its list of SelectItem from SelectItemSupport.getSelectItems(UIComponent,
Converter) directly, not using a protected method, effectively preventing that from being
overridden.
> The use cases are very scarce, but it should be possible to get the LoV from somewhere
else without forcing the use of f:selectItems. Specifically, it's the case when you want to
generate a dynamic component (always looking different) without altering the component tree
(which is bad when done in the render view phase and that would be the case here). Therefore,
the following non-final method should be added to SimpleSelectOneRenderer:
> protected List<SelectItem> getSelectItems(UIComponent component, Converter converter)
> {
>   return SelectItemSupport.getSelectItems(component, converter);
> }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message